Skip to content

Fix Windows Clippy warnings in store permissions - #1

Merged
ayushdoesdev merged 3 commits into
mainfrom
fix/windows-store-permissions-clippy
Nov 8, 2026
Merged

ayushdoesdev merged 3 commits into
mainfrom
fix/windows-store-permissions-clippy

Conversation

@ayushdoesdev

Copy link
Copy Markdown
Owner

Summary

  • Compile the Unix permission-mode constants only on Unix targets, where they are used.
  • Return the empty warning list directly on non-Unix targets, avoiding the Windows Clippy needless_return error.

Compatibility

  • Unix permission enforcement remains unchanged (0700 directories and 0600 files).
  • Non-Unix behavior remains unchanged: permission warnings are empty and OS-managed ACLs are left alone.
  • No CLI, configuration, snapshot-format, or restore behavior changes.

Validation

  • The change is intentionally limited to the Windows lint failures reported by the existing CI workflow.
  • Please use the full CI matrix on this PR to verify Windows, macOS, Ubuntu, and MSRV before merging.

@ayushdoesdev
ayushdoesdev merged commit 74fa9ca into main Nov 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant