Conversation
The release review left three call sites carrying look in `className`. Each turned out to be the visible end of a duplicated primitive, not a one-off. `CopyableValue` — `copy-row.tsx` and `secret-reveal-dialog.tsx` held the same box byte for byte: identical wrapper classes, identical `<span className="flex-1">`, identical ghost icon button. Two copies of a component, not two copies of a class string. The primitive owns the surface and the clipboard write; the toast and the translated labels stay in the app, where they belong. `Panel` — `rounded-md border p-3` appeared on a `<details>`, an `<li>`, a second `<details>` and a `<div>`. Four elements, one surface, so the primitive takes `asChild` rather than forcing everyone into a `<div>`. It is deliberately not `Card`: `Card` is `rounded-xl`, carries `shadow-sm`, `bg-card` and `hover-lift`, and is the page-level container — reusing it here would have made every nested box lift on hover. `CodeBlock` — `overflow-x-auto rounded bg-muted text-xs` on seven `<pre>` tags, three at `p-3` and four at `p-2`; the padding is the `size` variant. Three page titles moved from `<h1 className="text-2xl font-semibold">` to `TypographyH1 variant="page"`, which is what every other in-app page already uses — the raw class was not just off-system, it was a different size from the dashboard and the admin screens next to it. The webhooks catalog link drops its four cosmetic classes for `NavLink variant="plain"`, whose tone it was reproducing by hand. `features/legal/policies/index.ts` becomes `policies/bodies.ts`. It never was a re-export barrel — it resolves a locale to a policy body — but the filename made it read as one, and the rule is about the name as much as the content.
|
🎉 This PR is included in version 1.24.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One commit: the style debt the release review of #67 surfaced and left open.
Each of the three flagged call sites turned out to be the visible end of a duplicated primitive, not a one-off cosmetic slip:
CopyableValue—copy-row.tsxandsecret-reveal-dialog.tsxheld the same box byte for byte. The primitive owns the surface and the clipboard write; the toast and the translated labels stay in the app.Panel—rounded-md border p-3on a<details>, an<li>, a second<details>and a<div>, so it takesasChild. Deliberately notCard, which isrounded-xlwithshadow-smandhover-lift— reusing it would have made every nested box lift on hover.CodeBlock— the same class string on seven<pre>tags, three atp-3and four atp-2; the padding became thesizevariant.Also: three page titles moved to
TypographyH1 variant="page", matching every other in-app page (the rawtext-2xlwas a different size from the dashboard beside it), the webhooks catalog link dropped four cosmetic classes forNavLink variant="plain", andfeatures/legal/policies/index.tsbecamepolicies/bodies.ts.Gates green locally: Biome, type-check, knip, jscpd 1.19%, 871 api tests, 328 app tests, 28 a11y tests.
refactor→ patch. Merge commit, not squash.