Skip to content

ci: add release workflow - #222

Merged
maxday merged 11 commits into
masterfrom
maxday/test-release
Aug 14, 2026
Merged

ci: add release workflow#222
maxday merged 11 commits into
masterfrom
maxday/test-release

Conversation

@maxday

@maxday maxday commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Adds a workflow_dispatch release pipeline that builds the runtime library for x86_64 and aarch64, signs artifacts with a GPG key from Secrets Manager, and uploads them to a draft GitHub release.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

maxday added 7 commits August 14, 2026 00:28
Adds a workflow_dispatch release pipeline that builds the runtime library
for x86_64 and aarch64, signs artifacts with a GPG key from Secrets Manager,
and uploads them to a draft GitHub release.
The CodeBuild runners have no public internet egress, so the default
cdn.amazonlinux.com mirrorlist is unreachable. Point dnf at the regional
al2023-repos S3 bucket (reachable via the VPC's S3 gateway endpoint) and
disable the image's unreachable third-party repos.
Comment thread .github/workflows/release.yml Outdated
echo "No secret key imported from $GPG_SECRET_ID" >&2
exit 1
fi
echo "GPG_FINGERPRINT=$FPR" >> "$GITHUB_ENV"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like you are passing the GPG_FINGERPRINT to the generic $GITHUB_ENV you should take the GPG key sign and discard.

If one gets access to the workflow because of the vulnerability at a later action they get the GPG key.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put everything in the same step so we don't need to pass anything between steps

@vip-amzn
vip-amzn self-requested a review August 14, 2026 12:35
@maxday
maxday merged commit 3966fb1 into master Aug 14, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants