Remove unreachable OOM handling - #577
Open
azkrishpy wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The CRT allocators abort on failure rather than returning NULL —
aws_mem_acquire,aws_mem_callocandaws_mem_acquire_manyall route throughAWS_PANIC_OOM, which is anunconditional
exit(-1). The OOM branches guarded by these checks were therefore unreachable.Removes those checks and the error paths behind them, and folds a few acquire-then-zero pairs
into
aws_mem_calloc. No assert is added in their place: it would be dead in debug and compiledout in release, since the abort happens before control returns.
No behavior change. No new tests — the existing suite covers these paths and passes unchanged (745).
Part of the
todosstack (#576). Base istodos, notmain.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.