Skip to content

Add EKS Addon and IPv6 to OTelCI test - #2271

Open
Paamicky wants to merge 2 commits into
mainfrom
mcommey/eks-e2e-ci-addon-ipv6
Open

Add EKS Addon and IPv6 to OTelCI test#2271
Paamicky wants to merge 2 commits into
mainfrom
mcommey/eks-e2e-ci-addon-ipv6

Conversation

@Paamicky

@Paamicky Paamicky commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description of the issue

The OTel Container Insights EKS e2e test only ran the Helm installation path and only on IPv4. The EKS add-on install path (now released) and IPv6 were not covered, unlike the JMX e2e suite which runs both Helm and add-on on IPv4/IPv6.

Description of changes

  • EKSE2EOTELContainerInsightsTestHelmIPv6 (HELM_CHART, IPv6)
  • EKSE2EOTELContainerInsightsTestAddonIPv6 (EKS_ADDON, IPv6)

The add-on jobs point at resources/cwagent_configs_eks_addon/ci_node.json and set eks_installation_type: EKS_ADDON; IPv6 jobs set ip_family: ipv6 and the IPv6 test VPC. Terraform and the test harness already support both install types.

Integration Tests

OTELContainerInsights EKS Addon and IPv6 test passed:Addon path and IPv6


License

By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.

Requirements

  1. Run make fmt and make fmt-sh
  2. Run make lint

@Paamicky
Paamicky force-pushed the mcommey/eks-e2e-ci-addon-ipv6 branch from b3b1228 to 6f52422 Compare September 3, 2026 20:37
@Paamicky Paamicky changed the title Add Addon and IPv6 to OTelCI test Add EKS Addon and IPv6 to OTelCI test Sep 4, 2026
@Paamicky
Paamicky force-pushed the mcommey/eks-e2e-ci-addon-ipv6 branch from 6f52422 to 9c93396 Compare September 4, 2026 14:17
@Paamicky
Paamicky marked this pull request as ready for review September 4, 2026 14:18
@Paamicky
Paamicky requested a review from a team as a code owner September 4, 2026 14:18
@Paamicky Paamicky added the ready for testing Indicates this PR is ready for integration tests to run label Sep 4, 2026

@olowosulu olowosulu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues ↓

  • No evidence the new jobs were exercised. e2e-test.yml never runs on pull requests. Can you link a successful workflow_dispatch run of the three new jobs before merge?
  • job_id input is a no-op (eks-e2e-test.yml L15). Declared required but never referenced here...

@Paamicky

Paamicky commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Minor issues ↓

  • No evidence the new jobs were exercised. e2e-test.yml never runs on pull requests. Can you link a successful workflow_dispatch run of the three new jobs before merge?
  • job_id input is a no-op (eks-e2e-test.yml L15). Declared required but never referenced here...
  1. New jobs passed: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/33828184956
  2. job_id has been a no-op here since before this PR, so leaving it out of scope. Can file a follow-up to remove it.

@olowosulu
olowosulu self-requested a review September 8, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for testing Indicates this PR is ready for integration tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants