feat(payment): add manager and connector mutations - #2280
Closed
aidandaly24 wants to merge 4 commits into
Closed
Conversation
aidandaly24
added this pull request to stack #2278
September 11, 2026 14:22
aidandaly24
had a problem deploying
to
e2e-testing
September 11, 2026 14:22 — with
GitHub Actions
Failure
This was referenced Sep 11, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/payment-cud #2280 +/- ##
==================================================
Coverage 97.17% 97.17%
==================================================
Files 591 599 +8
Lines 40172 40808 +636
==================================================
+ Hits 39036 39656 +620
- Misses 1136 1152 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
# Conflicts: # src/core/payment.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second CUD layer of the payment stack, following identity-provider mutations in #2277.
Session/instrument mutations follow in #2281.
Adds:
payment manager create|update|deletepayment connector create|update|deleteIncludes existing default IAM service-role provisioning, ownership/collision
protections, Coinbase Quick Create, provider name/vendor resolution, and
authorization follow-up hints. Supplied/unowned roles are not modified, and
manager deletion does not delete IAM roles.
Session and instrument commands remain read-only in this layer, including balance.
The later data-plane layer adds their mutations. Code and tests are moved from
the original CUD implementation without changing these behaviors.
Updated against
refactorat4a235162. Quick Create/provider alternatives nowuse the shared
assertMutuallyExclusiveFlagshelper from #2263; the rule isunchanged and its error wording follows the shared standard.
Related Issue
Part of #2272.
Documentation PR
N/A. README documents manager creation, Quick Create, provider-backed connectors,
and IAM ownership.
Type of Change
Testing
RECORD=0 bun test: 3,344 passed across 234 files.bun run typecheck,bun run lint:check,bun run format:checkbun run build,bun run secrets:checkCommand tree, Core interface, and test stubs contain manager/connector mutations only.
IAM and payment Core remain unchanged; existing source-exclusivity assertions use the shared messages.
Linux, Windows, and macOS CI on
c537d6e9: https://github.com/aws/agentcore-cli/actions/runs/34625567618Uses the repository's Bun scripts rather than the npm scripts from the main-branch template.
No AWS resources were changed or live mutation fixtures re-recorded.
Checklist
PR #2277 is the outstanding dependency.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.