Skip to content

feat(payment): add manager and connector mutations - #2280

Closed
aidandaly24 wants to merge 4 commits into
feat/payment-cudfrom
feat/payment-manager-connector
Closed

feat(payment): add manager and connector mutations#2280
aidandaly24 wants to merge 4 commits into
feat/payment-cudfrom
feat/payment-manager-connector

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Second CUD layer of the payment stack, following identity-provider mutations in #2277.
Session/instrument mutations follow in #2281.

Adds:

  • payment manager create|update|delete
  • payment connector create|update|delete

Includes existing default IAM service-role provisioning, ownership/collision
protections, Coinbase Quick Create, provider name/vendor resolution, and
authorization follow-up hints. Supplied/unowned roles are not modified, and
manager deletion does not delete IAM roles.

Session and instrument commands remain read-only in this layer, including balance.
The later data-plane layer adds their mutations. Code and tests are moved from
the original CUD implementation without changing these behaviors.

Updated against refactor at 4a235162. Quick Create/provider alternatives now
use the shared assertMutuallyExclusiveFlags helper from #2263; the rule is
unchanged and its error wording follows the shared standard.

Related Issue

Part of #2272.

Documentation PR

N/A. README documents manager creation, Quick Create, provider-backed connectors,
and IAM ownership.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • RECORD=0 bun test: 3,344 passed across 234 files.

  • bun run typecheck, bun run lint:check, bun run format:check

  • bun run build, bun run secrets:check

  • Command tree, Core interface, and test stubs contain manager/connector mutations only.

  • IAM and payment Core remain unchanged; existing source-exclusivity assertions use the shared messages.

  • Linux, Windows, and macOS CI on c537d6e9: https://github.com/aws/agentcore-cli/actions/runs/34625567618

Uses the repository's Bun scripts rather than the npm scripts from the main-branch template.
No AWS resources were changed or live mutation fixtures re-recorded.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

PR #2277 is the outstanding dependency.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@aidandaly24
aidandaly24 added this pull request to stack #2278 September 11, 2026 14:22
@github-actions github-actions Bot added the size/xl PR size: XL label Sep 11, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 11, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Sep 11, 2026
@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 11, 2026
@codecov-commenter

codecov-commenter commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56469% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.17%. Comparing base (d7cd656) to head (c537d6e).

Files with missing lines Patch % Lines
src/handlers/payment/connector/delete/index.tsx 88.23% 4 Missing ⚠️
src/handlers/payment/connector/update/index.tsx 90.47% 4 Missing ⚠️
src/core/roleRetry.ts 86.66% 2 Missing ⚠️
src/handlers/payment/connector/create/index.tsx 97.59% 2 Missing ⚠️
src/core/paymentServiceRole.ts 99.06% 1 Missing ⚠️
src/handlers/payment/manager/create/index.tsx 98.68% 1 Missing ⚠️
src/handlers/payment/manager/delete/index.tsx 96.29% 1 Missing ⚠️
src/handlers/payment/manager/update/index.tsx 98.30% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           feat/payment-cud    #2280    +/-   ##
==================================================
  Coverage             97.17%   97.17%            
==================================================
  Files                   591      599     +8     
  Lines                 40172    40808   +636     
==================================================
+ Hits                  39036    39656   +620     
- Misses                 1136     1152    +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Sep 11, 2026
# Conflicts:
#	src/core/payment.tsx
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Sep 11, 2026
@github-actions github-actions Bot added size/xl PR size: XL and removed size/xl PR size: XL labels Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants