chore(deps): docker: bump mise digest and golang 1.26.4 to 1.27.1 - #873
Merged
Conversation
The safe two-thirds of #827. Both lines are byte-identical to that PR; only the third change is left behind. - jdxcode/mise: digest refresh, same `latest` tag. - golang: 1.26.4-bookworm -> 1.27.1-bookworm. Build-only — the `gh-builder` stage compiles the `gh` CLI and is discarded, so it cannot reach the runtime image. Held back: python:3.13-slim -> python:3.14-slim. That moves the agent's runtime interpreter while `agent/mise.toml` still pins python 3.13, the ty/ruff target in `agent/pyproject.toml` is still 3.13, and the CVE-patching comment in this file still names the 3.13 base tag. It needs its own PR landing with those three, not a digest refresh. #871 adds a dependabot ignore so the interpreter always arrives separately.
ayushtr-aws
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the safe portion of #827. Related: #871.
Change
Two of #827's three base-image bumps, byte-identical to that PR (verified by diffing
agent/Dockerfilelines 22 and 25 againstrefs/pull/827/head):The golang bump affects only the
gh-builderstage, which compiles theghCLI and is then discarded, so it cannot reach the runtime image.What this deliberately leaves behind
build (agentcore)is green on #827, so that bump does build and the suite does pass — this is not a claim that it is broken. The problem is that it moves the agent's runtime interpreter while three other places still say 3.13:agent/mise.toml:4—python = "3.13", so local development and the container would run different minors.agent/pyproject.toml:184—python-version = "3.13"is the ty/ruff target, so type-checking would no longer describe the runtime. (requires-python = ">=3.13"at:5does permit 3.14, so that one is not violated.)agent/Dockerfile:44— the CVE-patching comment names thepython:3.13-slimtag explicitly, and would become a false reference in the same commit.For a dependency set this C-extension-heavy (pydantic, boto3, the OpenTelemetry distro), an interpreter bump is worth validating on its own and landing together with those three pins. #871/#872 adds a dependabot
ignoreforpythonmajor/minor on the docker ecosystem so it always arrives as its own reviewable change, while digest and patch refreshes keep flowing.Testing
Correction to an earlier version of this description: it claimed CI's
build (agentcore)builds the image. It does not. There is nodocker buildin any workflow (grep -rn "docker build\|buildx\|DockerImageAsset" .github/workflows/is empty);build.ymlrunsmise run build, whose DAG never realises theDockerImageAsset, and the only task that builds this Dockerfile —//agent:security:image(agent/mise.toml:61) — is reachable solely frommise run securityinsecurity.yml, which isworkflow_dispatch+ a Monday0 12 * * 1cron. So green checks here are not evidence for a base-image change. That observation is due to the standing review on #827 (its B2); I verified it independently before relying on it.So I built and scanned it locally instead — both halves of
//agent:security:image, onlinux/arm64.Build: succeeds. Verified by artifact rather than exit code:
gois absent from the final image, confirming thegh-builderstage is discarded as claimed; the toolchain version above comes from--target gh-builder.Trivy: this is the part worth reading. I scanned an image built from clean
upstream/mainand one from this branch with the task's exact flags, and diffed the HIGH/CRITICAL sets:All 9 are Go
stdlibCVEs inusr/local/bin/gh— CVE-2026-33818, -39821, -39822, -46600, -56853, -56858, -56859, -56860, -56862 — cleared becauseghis now compiled with go1.27.1 instead of 1.26.4. That is precisely the rationale the Dockerfile gives at line 24 for buildingghfrom source rather than taking a distro package, so this bump is doing the job it exists to do.Note the scan exits 1 on both images: 14 findings remain on this branch (gh's Go module dependencies, four Node packages, and
quinn-protoinuv), all pre-existing onmainand none introduced here. Worth a separate look, since it means the Monday security cron is currently red.Follow-up
#827 stays open until #872 merges, then it can be closed — with the PR limit still at 1 and no
pythonignore in place, closing it today just returns the same three-way group on the next Saturday run. Same sequencing as #859 and #860.The Python 3.14 migration already has an issue — #105 — which is open and not yet
approved. Per the #827 review it also needs two checklist items it currently omits:agent/mise.toml:4andagent/.python_version.CI note
Secrets, deps, and workflow scanis red, and not because of anything here — this PR does not touchyarn.lock.osv-scannerreports the same 7 advisories across 5 npm packages on this branch as onmain: astro ×2 (incl. GHSA-26w7-cxv4-gfx2 at 9.8), js-yaml, sharp, smol-toml, and svgo ×2. Every branch cut frommaininherits them, which is what #870 ("clear 7 osv advisories blocking the merge queue") exists to fix. #870 is already approved; once it merges, rebasing this should turn the check green.