TOOLS-37: bridge canonical and legacy client provisioning - #37
Merged
Conversation
Preserve existing Pi clients with paired canonical and legacy exports from one validated authority. Converge managed shell configuration without mutating credentials, retain consumer cutover gates, and cover unsafe parent paths. Fix the three separately approved baseline E2E lint findings so the full tagged check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Migrate the agent-tools provisioning producer without breaking existing Pi clients. This is a dual-export transition, not canonical-only cutover.
Changes
configure-agent-gateway.sh, canonical transfer-path support and one canonical managed shell block. Retain the old standalone entry point becausesb provisioncopies each script individually.Review Notes
Independent review and focused repair confirmation found no remaining material findings at the pre-publication boundary. The unsafe empty-parent fallback was reproduced and repaired.
Producer-first rollout: this compatibility PR can ship before agent-config migrates. Delivered agent-config
fadc9ac8d681f27bf9c8e5f59fc56011a0d512b1accepts the retained legacy variables; its real loader was qualified with the old producer and both transition entry points using synthetic isolated material. Canonical-consumer integration is deferred until that consumer is delivered and remains required before canonical-only provisioning or alias retirement—not before this dual-export PR. No external repository edits, credential operations, live rollout, native-keyring qualification or release acceptance are claimed. CI is not proof of rollout.Test Plan
Passed locally on Linux:
make -C agent-gateway verify(memory-limited Go scheduling; no checks suppressed).make fmt-checkand repository pre-commit formatting/lint. A killed mcp-broker lint process was rerun independently and passed.go -C agent-gateway tool golangci-lint run --build-tags=e2e ./test/e2e: full scan, zero issues.make -C agent-gateway test-e2e: full count-one race-enabled owner after shared-fixture repairs. After the isolated directory-preflight repair, reused unchanged fixture evidence and reran all currentTestProvisionGateway*tests with-race -tags=e2e -count=1.bash -n;git diff --check.All 11 required checks, including Required, passed at
3853aca711aecf5d15b646134178193f9c46135fin CI run 34775956426, attempt 1; fresh authoritative reads confirmed the complete set. New-consumer integration remains not run and belongs to the subsequent consumer/canonical-only rollout, not this compatibility producer's readiness gate.