Feature/persian implementation - #5
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de5d5dda18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| LANG_FILE_CODES = { | ||
| 'Persian': 'fa', | ||
| } |
There was a problem hiding this comment.
Normalize Persian CLI aliases to the canonical target
When server.py translate is invoked using the CLI's established short-code convention (-t fa; --help itself shows the lowercase default ru), this mapping only affects the output filename while the original target_lang remains fa. Consequently, upload_to_cache() and save_to_local_db() persist fa, whereas the extension and managed-backend flow use the canonical value Persian, splitting Persian cache/database records and causing canonical-language queries to miss CLI translations. Normalize accepted aliases such as fa and case variants before translation, cache-key construction, and persistence.
Useful? React with 👍 / 👎.
|
Fixed in the latest commit. Persian CLI aliases now normalize to the canonical |
Summary
Adds Persian/Farsi support to Podstr.
Changes
Testing
The managed backend still needs production verification for the canonical target value
Persian.