Skip to content

Feature/persian implementation - #5

Open
BlankuApp wants to merge 4 commits into
aveleazer:mainfrom
BlankuApp:feature/persian-implementation
Open

Feature/persian implementation#5
BlankuApp wants to merge 4 commits into
aveleazer:mainfrom
BlankuApp:feature/persian-implementation

Conversation

@BlankuApp

Copy link
Copy Markdown

Summary

Adds Persian/Farsi support to Podstr.

Changes

  • Adds Persian as a translation target.
  • Adds the Persian Chrome locale and translated UI messages.
  • Adds RTL handling for the popup and subtitle display.
  • Adds Persian subtitle language detection.
  • Adds Persian translated subtitle credits.
  • Adds Persian README documentation.
  • Adds Persian filename mapping in the server CLI.

Testing

  • Loaded the extension in Chrome using Developer mode.
  • Tested Persian UI and RTL layout.
  • Tested Persian subtitle translation on a real video.

The managed backend still needs production verification for the canonical target value Persian.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de5d5dda18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread server/server.py
Comment on lines +51 to +53
LANG_FILE_CODES = {
'Persian': 'fa',
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize Persian CLI aliases to the canonical target

When server.py translate is invoked using the CLI's established short-code convention (-t fa; --help itself shows the lowercase default ru), this mapping only affects the output filename while the original target_lang remains fa. Consequently, upload_to_cache() and save_to_local_db() persist fa, whereas the extension and managed-backend flow use the canonical value Persian, splitting Persian cache/database records and causing canonical-language queries to miss CLI translations. Normalize accepted aliases such as fa and case variants before translation, cache-key construction, and persistence.

Useful? React with 👍 / 👎.

@BlankuApp

Copy link
Copy Markdown
Author

Fixed in the latest commit. Persian CLI aliases now normalize to the canonical Persian value before translation, cache-key construction, and persistence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants