Skip to content

fix local logs, only run our images on the "apps" profile - #272

Open
andyshinn wants to merge 2 commits into
mainfrom
ashinn/minor-local-logs-fixes
Open

andyshinn wants to merge 2 commits into
mainfrom
ashinn/minor-local-logs-fixes

Conversation

@andyshinn

@andyshinn andyshinn commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Changes are limited to dev tooling, compose profiles, observability config, and CI build ordering with no production auth or data-path changes.

Overview
Local dev logging now writes to ./logs via LOG_PATH in VS Code launch configs, and Alloy bind-mounts that directory and scrapes bridger.log, bot.log, and http.log alongside the existing container paths so host-run Python services show up in Loki.

Compose puts bridger, bot, and http behind the app profile, so a default docker compose up can bring up infra (Influx, EMQX, etc.) without always building/running the app images.

CI sets sequential: true on the multi-platform simple-proxy Buildah step to avoid parallel amd64/arm64 builds racing on shared storage and failing with “image not known”.

Reviewed by Cursor Bugbot for commit af7986f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI lite review requested due to automatic review settings September 12, 2026 01:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update the README commands to activate the app profile or document the infrastructure-only workflow.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This pull request improves local development logging and makes application containers opt-in through the Compose app profile.

Changes:

  • Configures VS Code launch log paths.
  • Adds host log collection to Alloy and Compose.
  • Updates editor theme colors.
File summaries
File Description
config/alloy/config.alloy Adds host development log targets.
compose.yaml Adds the app profile and host log mount.
.vscode/settings.json Updates theme colors.
.vscode/launch.json Configures per-process log paths.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread compose.yaml
depends_on:
- influxdb
- emqx
profiles:

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit af7986f. Configure here.

platforms: linux/amd64,linux/arm64
# Parallel per-platform builds share one containers storage and race over the base
# image name, so whichever loses hits "image not known" partway through.
sequential: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown sequential input is ignored

Medium Severity

redhat-actions/buildah-build@v3 has no sequential input, so this key is ignored and multi-arch builds still run in parallel. The shared-storage race over the base image name remains, and the simple-proxy step can still fail the build job with image not known.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit af7986f. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants