Repository navigation
refactor(nextjs)!: retire legacy Document plugins - #284
Merged
TorinAsakura merged 3 commits intoOct 13, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fb013b86e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
next-document-with-helmet,next-document-with-gtag,next-document-with-iconsиnext-document-with-opengraph. Вместе с ними удаляются React 19 форк Helmet, локальный Yarn patch типов, записи в README и четыре major-решения. Identity integration и sitemap generator сохраняются.masterотдельно пометить опубликованные версии четырёх пакетов как deprecated в npm. Этот PR не меняет реестр.Проверка прежнего эффекта и штатного пути для новых приложений:
next-document-with-gtaggtag.jsnext/script;GoogleTagManagerиз пока экспериментального@next/third-parties/googlenext-document-with-iconslink rel=iconиapple-touch-iconnext/headс нужнымиlinknext-document-with-opengraphmeta property=og:imagenext/headсmetaДля Helmet-кейсов title и meta покрывает
next/head;html langтребует отдельной передачи локали в_document. Serenity сейчас в рефакторинге и не служит проверкой работающего потребителя. Опубликованные версии остаются в npm до отдельного deprecation-шага после доставки вmaster.Как проверять
build/nextjs-workspace-release.Действие: выполнить
node .yarn/releases/yarn.js install --immutable,node .yarn/releases/yarn.js workspaces list --jsonи поиск ссылок на четыре Document-пакета в manifest, lockfile и исходниках.Ожидаемый результат: установка не меняет lockfile; список содержит только identity integration и sitemap generator, а четыре Document workspace, форк и patch отсутствуют.
Действие: выполнить
node .yarn/releases/yarn.js check --verify,node .yarn/releases/yarn.js workspaces foreach -A -t --no-private run build,node .yarn/releases/yarn.js version checkиnode .yarn/releases/yarn.js version apply --all --dry-run.Ожидаемый результат: проверки и сборки проходят; dry run оставляет только два patch-релиза, без Document-пакетов.
Пруфы
rgне находит ссылок на четыре Document-пакета или Helmet-зависимости; Yarn перечисляет только два публичных workspacenext/headи Google Third Parties для Pages Router