Repository navigation
Feat/update checkbox - #819
Conversation
BREAKING CHANGE: Replace active/defaultActive/onCheck with checked/defaultChecked/onChange. Use checkedIcon instead of icon. Refs now target the native input. Remove CheckboxAppearanceName and the blue/green/red appearance variants. Rename size keys small/medium/large to sm/md/lg. CheckboxShape and CheckboxAppearance now use new structures; consumers of the old exports and values must migrate.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a6cf39fed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d2b86399c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5ce6b1220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4941242aee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
TorinAsakura
left a comment
TorinAsakura
left a comment
There was a problem hiding this comment.
В BREAKING CHANGE перечислены переходы на checked/defaultChecked/onChange, checkedIcon и ref на нативный input, но не указаны остальные изменения публичного API. Удаляются CheckboxAppearanceName и варианты blue/green/red; ключи размеров меняются с small/medium/large на sm/md/lg, а типы CheckboxShape и CheckboxAppearance меняют структуру. Потребители старых экспортов и значений получат ошибки типов. Добавь эти миграции в описание breaking change.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d22670a57c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d22670a to
c678c27
Compare
Таска
Как проверять
Контекст: Storybook → Components → Checkbox → «Базовый»
Действие: кликнуть по checkbox несколько раз
Ожидаемый результат: состояние переключается между checked и unchecked, меняются фон, border, тень и иконка
Контекст: Storybook → Components → Checkbox → «Кастомный»
Действие: кликнуть по checkbox
Ожидаемый результат: checkbox переключается и сохраняет переданные
classNamesиcheckedIconКонтекст: Storybook → Components → Checkbox → «Базовый»
Действие: в Safari нажать
Option + Tab, затемSpaceОжидаемый результат: checkbox получает focus и переключается по
SpaceПримечание: обычный
Tabв Safari требует включить “Press Tab to highlight each item on a webpage”Контекст: Storybook Controls
Действие: включить
indeterminate, затем кликнуть по checkboxОжидаемый результат: появляется иконка minus; после клика indeterminate снимается и checkbox становится checked
Контекст: Storybook Controls
Действие: включить
disabledОжидаемый результат: checkbox не переключается, применяются disabled-стили
Пруфы
Details
2026-10-23.16.43.18.mov
2026-10-23.16.42.37.mov