Repository navigation
13: fix: remove the photograph and make every page findable - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Removes the photograph and makes the ten pages findable.
The picture. Gone. A deliberately out of focus photograph reads as a mistake rather than as
discretion, and nothing is better than that.
Why the pages could not be found. Three faults, all mine.
Every service title was a link styled
text-inkwith no underline, so a heading that was a linklooked exactly like a heading that was not. The eight pages were on the home page the whole time
with nothing signalling they were clickable. They now take the accent colour and an underline.
The header carried two links,
ServicesandWork, both pointing at/services, and both hiddenbelow 640px with nothing replacing them. A phone had a wordmark and a mail button and no navigation
at all. There is now one honest link, visible at every width, and
Workis gone until there is awork page for it to point at.
The footer had one mailto link and nothing else. It now lists every page in three columns, on every
page, which is how a visitor and a crawler both find depth.
Tests. 40. Three added for this: a service link has to carry a visual affordance, every service
page has to be reachable from the footer of every page, and the header must not offer a link that
goes somewhere other than it says. Two were mutation checked, by setting the links back to
text-inkand by emptying a footer column.One existing assertion was stale and is corrected rather than deleted: the 404 test checked that the
page did not contain the tagline, and the tagline is now in the footer of every page, so it checks
the heading instead.
Part of #2.