Repository navigation
13: fix: check in the image type declarations so the typecheck stands alone - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Checks in the type references Next normally generates, so
tsc --noEmitno longer dependson a file that only exists after a build.
Why.
mainwent red onCannot find module '@/images/whiteboard.jpg'. The types for a staticimage import come from
next-env.d.ts, which Next generates on a build and gitignores. My local runpassed because an earlier build had left that file behind. A fresh checkout, which is what the
pipeline has, does not have it.
I removed the generated file locally and reproduced the failure, added the references, and confirmed
it passes without it. Then I deleted the new file and watched it fail again, so the fix is what is
doing the work rather than something else.
How it got to main. I merged #37 while its check was still running. My wait loop exited on a
state that was not literally
PENDING, and I did not check the result before merging. That is onme, and the deploy stopped at the type step, so nothing broken reached production.
Part of #2.