Repository navigation
docs: name pull request 4 as the subject to land - #7
Closed
juliantellez wants to merge 1 commit into
Closed
juliantellez wants to merge 1 commit into
juliantellez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Records which open pull request is next to land, in
subject.md. The next step is a newsession that reads nothing from this one, so the file carries the number, the title, the head
branch, the head commit, the conflict state and the failing check.
Why. Pull request 4 is the older of the two open ones. It does not conflict, and one check on
its head commit failed:
plan and apply.That check does not appear in
gh pr checks 4, which printscodeandinfrastructure, says bothpass, and exits 0. The
deployworkflow runs on a push tomainand on a manual start, never on apull request, so GitHub keeps its run out of the pull request summary. Reading the head commit
shows it:
Two things the file records that a reader needs. Every
deployrun in the repository failed, onmainas well as on that branch, so pull request 4 does not cause the red check. Andmainhas nobranch protection, so no check is required and none blocks a merge.
Pull request 5 is an earlier round of this same task and names the same subject. It is still open.
Both add
subject.mdat the root, so whichever merges second will conflict.