Repository navigation
docs: record what landing pull request 4 found - #12
Closed
juliantellez wants to merge 2 commits into
Closed
juliantellez wants to merge 2 commits into
juliantellez wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. Adds
docs/landing-pull-request-4.md. It records what landing pull request 4 found.Why. Pull request 4 has one red check,
plan and apply. That check does not appear in the pullrequest summary, because the
deployworkflow does not start on a pull request. The report namesthe check, the log and the cause, so the next reader does not repeat the diagnosis.
The branch of pull request 4 needed no merge.
origin/mainis already its base. Every gate that canrun passes on it: the typecheck, the linter, 114 tests, the build, the package check,
terraform fmtandterraform validate.The red check is a correct gate. It asks the deployed page for a transcript, and the page cannot
give one. The platform refuses the address the function calls from. The function log records
"cause":"bot_check"and"playability":"LOGIN_REQUIRED". The same code read 560 caption segmentsfrom a sandbox, so the code is not the fault. Every
deployrun in this repository failed,including the runs on
main, so pull request 4 inherits this failure rather than causing it.To make that step pass, the function needs a different address to call from. Each way to get one
bills money while nobody visits. The project context refuses two of them by name. So this is a
decision for a person, and the report says so.
This pull request adds one file that no other open pull request touches.