Repository navigation
EMI: feat: give the phase guide short tips and say that everyone is different - #368
Merged
Merged
Conversation
# Conflicts: # apps/mobile/src/app/(tabs)/log/index.tsx # apps/mobile/src/language/russian.ts # apps/mobile/tests/fixtures/theFirstRunLook.tsx # brand/screens/onboarding.html # brand/screens/onboarding.png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. The phase guide now gives one short, practical tip for each area of each phase, and it ends with one line that says everyone is different. The guide title names the phase in plain words, for example "Before your period: what may help", and the Home card names it the same way. The lines of issue 323 that change the meaning also change, in English, Spanish and Russian.
Why. The beta group said the guide read like a lecture and did not help. Polina asked for short tips, plain names for the phase, and a line that people feel different things. Step 24 (#362) changed the Russian only lines. This step does the lines that change the meaning in all three languages.
Stack. 1. #362 (step 24). 2. This pull request (step 30), based on the branch of 362. Merge 362 first.
Pictures. iPhone SE (3rd generation). In each row: the board where one exists, then the app before (the branch of step 24), then the app after (this branch).
Phase guide, English (the design is the phaseGuide board)

Phase guide, Russian

Home, ring and phase card, English

Home, ring and phase card, Russian

Day entry, Russian (after only)

I captured the pictures on the simulator from Metro on this checkout. The before pictures are the branch of step 24 at
992a406. The after pictures are this branch, with the app code ofe7d019d. They are observed, not rendered. The phone holds a luteal day (day 20 of 28), so the after guide shows the luteal tips. The other three phases are in the tests and in the text below.Issue. Closes #323: #323. The issue closes together with #362, which is merged first.
Draft text for review. Each changed key, in English, Russian and Spanish, old and new. Polina wrote the four luteal tips, the luteal title, the line that everyone is different, «Фаза определена приблизительно.», «Отметьте всё, что подходит.», «Здесь появятся ваши наблюдения» and «Запись за сегодня». I wrote the other three phases in the same shape, because she did not review them.
home.phaseCard.estimatehome.phaseCard.period.dayhome.phaseCard.period.dayshome.phaseCard.follicular.dayhome.phaseCard.follicular.dayshome.phaseCard.morehome.phaseCard.ovulation.dayhome.phaseCard.ovulation.dayshome.phaseCard.luteal.dayhome.phaseCard.luteal.dayslog.title.todayonboarding.today.questionphase.guide.everyonephase.guide.follicular.bodyphase.guide.follicular.foodphase.guide.follicular.moodphase.guide.follicular.trainingphase.guide.foodphase.guide.luteal.bodyphase.guide.luteal.foodphase.guide.luteal.moodphase.guide.luteal.trainingphase.guide.openphase.guide.ovulation.foodphase.guide.ovulation.moodphase.guide.ovulation.trainingphase.guide.period.bodyphase.guide.period.foodphase.guide.period.moodphase.guide.period.trainingphase.guide.title.follicularphase.guide.title.lutealphase.guide.title.ovulationphase.guide.title.periodphase.guide.trainingphase.past.heading.waitingDecisions.
Checks.
make check: patches, format, lint, typecheck, documents, brand, reference, sheet, features, story, pictures and mockups pass. Workspace tests 124 of 124 and 1862 of 1862. Mobile tests 3620 of 3621. The one failure is test 10.7, the known local noise: the ~/.npmrc on this Mac prints "always-auth" and "email" warnings into the generator output. The lint step prints two warnings in exportScreen.picture.tsx, which this change does not touch.npm run test:behaviour: 93 of 93 pass.grep -c itvrepos package-lock.jsonprints 0.