Repository navigation
EMI: feat: reword the reminder screen and notification in three languages - #367
Merged
Merged
Conversation
# Conflicts: # brand/screens/onboarding.html # brand/screens/onboarding.png # features/2-she-logs-her-first-period.feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What. The reminder screen and the reminder notification get new words in English, Spanish and Russian, from Polina's Russian meaning. The lock screen now says only "A reminder from Emi".
Why. In the beta, "when it is near" read like a pregnancy due date, and "Your forecast starts" was unclear. She asked for a direct question and a neutral notification.
Stack. 1. #361 (step 23, the base). 2. This pull request (step 29). Steps 26 (#364), 27 (#365) and 28 (#366) sit on the same base and touch other keys. Merge 361 first.
Reminder screen, English, iPhone SE. Before, then after.

Reminder screen, Russian, iPhone SE. Before, then after.

The pictures are observed on the iPhone SE simulator, with "2 days before" pressed. Before: branch
emi-fix-russian-first-run-wordingat f229f90. After: this branch, the code of commit b27e6a8, served by Metro from this checkout. The after pictures are scrolled down by about 60 points, because on the iPhone SE the screen scrolls once the line under the question shows. No real notification was scheduled.Issue. Closes #322 (#322). This is the last step for 322. The issue closes together with #361, #364, #365 and #366.
Draft text for review
Each line: key, then English, Russian and Spanish, old and new.
onboarding.reminder.titleEnglish: "Shall Emi tell you when it is near?" becomes "Would you like a reminder before your period?"
Russian: "Напомнить о приближении месячных?" (no change, step 23 set it)
Spanish: "¿Quieres que Emi te avise cuando esté cerca?" becomes "¿Quieres un recordatorio antes de tu regla?"
onboarding.reminder.question(new key, a line under the title)English: "When would you like to be reminded?"
Russian: "Когда вам напомнить о месячных?"
Spanish: "¿Cuándo quieres que te lo recordemos?"
onboarding.reminder.choice.twoDaysBefore/.oneDayBefore/.onTheDayEnglish: "Two days before" / "One day before" / "On the day" become "2 days before" / "1 day before" / "On the expected start date"
Russian: "За 2 дня" / "За 1 день" / "В день предполагаемого начала" (no change)
Spanish: "Dos días antes" / "Un día antes" / "El mismo día" become "2 días antes" / "1 día antes" / "El día previsto de inicio"
onboarding.reminder.line.twoDaysBefore(shows after she picks)English: "Two days before the range starts." becomes "The reminder comes at 9 in the morning. Your period may start about 2 days later."
Russian: "За два дня до начала диапазона." becomes "Напоминание придёт в 9 утра. Месячные могут начаться примерно через 2 дня."
Spanish: "Dos días antes de que empiece el rango." becomes "El recordatorio llega a las 9 de la mañana. Tu regla puede empezar unos 2 días después."
onboarding.reminder.line.oneDayBeforeEnglish: "One day before the range starts." becomes "The reminder comes at 9 in the morning. Your period may start the next day."
Russian: "За один день до начала диапазона." becomes "Напоминание придёт в 9 утра. Месячные могут начаться на следующий день."
Spanish: "Un día antes de que empiece el rango." becomes "El recordatorio llega a las 9 de la mañana. Tu regla puede empezar al día siguiente."
onboarding.reminder.line.onTheDayEnglish: "On the day the range starts." becomes "The reminder comes at 9 in the morning. Your period may start that day."
Russian: "В день, когда начинается диапазон." becomes "Напоминание придёт в 9 утра. Месячные могут начаться в этот же день."
Spanish: "El día en que empieza el rango." becomes "El recordatorio llega a las 9 de la mañana. Tu regla puede empezar ese mismo día."
onboarding.reminder.actionEnglish: "Remind me" becomes "Turn on reminders"
Russian: "Включить напоминания" (no change)
Spanish: "Avísame" becomes "Activar recordatorios"
reminder.notification(one new key in place of three; this is the lock screen text)English: "Your forecast starts in two days." / "tomorrow." / "today." becomes "A reminder from Emi"
Russian: "Ваш прогноз начинается через два дня." / "завтра." / "сегодня." becomes "Напоминание от Emi"
Spanish: "Tu previsión empieza en dos días." / "mañana." / "hoy." becomes "Un recordatorio de Emi"
onboarding.reminder.notNowstays "Not now", "Не сейчас", "Ahora no".Decisions
questionslot.месячн,periodand the other stems in the notification. So the notification is the neutral "A reminder from Emi", the same for every moment, as she asked. Her example "Месячные могут начаться примерно через 2 дня." becomes the second sentence of the line under the question.whenToRemindHerinapps/mobile/src/features/reminder/reminder.tsraises the reminder atreminderHour(9, local time) on the first day of the forecast range minus 2, 1 or 0 days. So at that moment the period may start 2 days later, the next day or that day. The hour in the copy is the{hour}placeholder, filled fromreminderHour, so the text cannot drift from the code.rescheduleHerRemindernow schedulesreminderNotificationWordsas the body.reminder.notification.*keys are gone. "Remind me" becomes "Turn on reminders" in the scenario names.Checks
make check: format, lint (0 errors, 2 warnings inexportScreen.picture.tsx, not this change), typecheck, documents, brand, features, story, pictures and mockups pass. Workspace tests 124 of 124. Mobile tests 3591 of 3592: the one failure is test 10.7, the known local noise from the "always-auth" and "email" warnings of ~/.npmrc.npm run test:behaviour: 92 of 92. The claims gate and the naming tests 23.2 to 23.6 pass.grep -c itvrepos package-lock.jsonprints 0.Mutation check: the
onTheDayline incopy.tswas pointed at theoneDayBeforekey. The new test "says the hour the reminder comes at and what it means" went red. With the file restored, it went green.