Repository navigation
Share the desktop frame host and finish the first texture and depth samples - #4
Closed
atcarter714 wants to merge 1 commit into
Closed
atcarter714 wants to merge 1 commit into
atcarter714 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HelloTexture opened a blank window with an empty asset loader and an incomplete shutdown path. It now ports Microsoft's D3D12 Hello Texture checkerboard triangle and closes through the same frame host as ModernTriangle.
DXSharp.Framework.Desktopowns the WinForms loop, draw submission, resize, presentation and teardown. Samples supply their own scene resources and draw callback. The host uses one allocator and waits for each draw submission.Stacked on #3, whose resize and minimize behavior the maintainer verified on an RTX 3080 Ti. All four CI jobs passed at
2018c69. WARP presented after both ModernTriangle resizes. HelloTexture and AdvancedSample each rendered four frames and exited successfully. Windows Debug and Release also passed the package consumer checks. The desktop sample notes identify Hello Frame Buffering, ExecuteIndirect and D3D12 Multithreading as the next Microsoft ports.Consolidated by the preview 1 release in #9 and retained in
mainthrough #31. Verification: this PR head is an ancestor ofrelease/automationat1ba30ff4a36b6c4a7f8a31f342599026178c2cd0, whose tree1c2649258445a6a22abeaa58cbc139c9384d0c5fexactly matches released main commit0dcb5e3fbb984c23a1f313c87ec72ea0cbfe5fc4. Follow-up SDK work is tracked in #32–#35.