Repository navigation
Copy bundles to deployment previews - #168
Open
jeremybeard wants to merge 1 commit into
Open
jeremybeard wants to merge 1 commit into
jeremybeard wants to merge 1 commit into
Conversation
jeremybeard
added this pull request to stack #169
October 15, 2026 17:25
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 15, 2026 19:03
ede0880 to
534c6fc
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 15, 2026 19:30
534c6fc to
b74f807
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 16, 2026 18:00
b74f807 to
976eca9
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 16, 2026 18:06
976eca9 to
d4e452b
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
2 times, most recently
from
October 16, 2026 18:25
062180f to
f431dea
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 16, 2026 18:37
f431dea to
3752474
Compare
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 16, 2026 18:40
3752474 to
fa20c77
Compare
jeremybeard
marked this pull request as ready for review
October 16, 2026 19:11
wendtek
approved these changes
Oct 16, 2026
neel-astro
approved these changes
Oct 19, 2026
| else | ||
| # with ASTRO_API_TOKEN set, the CLI prints "Using an Astro API Token" to stdout ahead of the JSON | ||
| list_bundles() { | ||
| astro deployment bundle list --deployment-id "$1" --json | jq -Rsc 'sub("^[^{]*"; "") | fromjson | .bundles // []' |
Collaborator
There was a problem hiding this comment.
curious q: will this fail loudly or silently with empty list for deployments that do not support bundles?
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 19, 2026 13:19
fa20c77 to
a22d955
Compare
Co-Authored-By: Claude <[email protected]>
jeremybeard
force-pushed
the
preview-bundle-copy
branch
from
October 19, 2026 14:34
a22d955 to
cdb7fbc
Compare
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deployment preview is cloned from
astro deployment inspect --template, which carries no bundles, so a named-bundle deploy to a preview failed.create-deployment-previewnow copies the original deployment's bundles: DAG bundles by name, then non-DAG bundles with their mount path, type, and links to the preview's DAG bundles of the same names. It skips the copy with a notice on CLIs older than 1.44.0, and with a warning on runners withoutjq.Contents aren't copied; the README says to add each bundle's deploy step to the workflow that creates the preview. A
dags-onlystep on a new preview now deploys its DAGs.E2E: the preview test registers a named DAG bundle and a linked non-DAG bundle on the original deployment, and checks both reach the preview with the link remapped. Its bundle lookup now matches a deploy by any of its bundles, since the preview's deploys list several.