Skip to content

refactor(search)!: PropertiesListResolver hands out Map.Entry, and silly-bean goes (#53) - #57

Merged
astrapi69 merged 3 commits into
developfrom
chore/53-drop-silly-bean
Nov 7, 2026
Merged

astrapi69 merged 3 commits into
developfrom
chore/53-drop-silly-bean

Conversation

@astrapi69

Copy link
Copy Markdown
Owner

Closes #53

silly-bean is archived (astrapi69/silly-bean#37, the maintainer's decision of 2026-11-06); its users migrate in their own repositories. resourcebundle-core used it in one place: PropertiesListResolver kept its result as List<KeyValuePair<File, Locale>>, public through Lombok's @Getter as getPropertiesList(). It hands out the JDK's Map.Entry now, which changes the getter's type, so develop opens the major 7.0.

What changes

  1. test(search): pin what PropertiesListResolver resolves, as KeyValuePair today (#53) (e716281)
    • testResolve: a tree built at runtime; each properties file, also in a subdirectory, comes with the locale of its name (messages_de German, messages_de_DE Germany), the default locale for a file without one, no entry for readme.txt. It reads the entries through today's element type, so the next commit shows the type change in the test.
  2. refactor(search)!: PropertiesListResolver hands out Map.Entry, and silly-bean goes (#53) (1865131)
    • List<Map.Entry<File, Locale>>, each an AbstractMap.SimpleImmutableEntry (JDK first; unlike Map.entry it does not refuse a null value); getKey() and getValue() stay
    • silly-bean out of gradle/dependencies.gradle, gradle/libs.versions.toml and module-info.java (requires io.github.astrapisixtynine.silly.bean)
  3. build: develop opens the major 7.0, for the getter type of #53 (f03ce9d)
    • projectVersion 6.2-SNAPSHOT to 7.0-SNAPSHOT, the form of the last major, 6.0 (RL-060)

Who has to change

git grep over the local checkouts' default branches: bundle-app-ui (on resourcebundle-core 5) names the type in ApplicationDashboardContentPanel (260), ImportWizardPanel (171), ConvertExtensions (29, 34, 53) and BundleFileTableModel (46); it changes KeyValuePair<File, Locale> to Map.Entry<File, Locale> when it moves to 7.0. No other caller of PropertiesListResolver (the inventory of #53).

Still on the runtime class path

./gradlew dependencies --configuration runtimeClasspath: silly-bean 2 comes through silly-collection 28 and file-worker 17.4; this repository neither declares nor uses it any more. It goes when those two are raised to versions without it.

Evidence

JDK 17.0.20 (Temurin; the workflow sets up '17'), ./gradlew spotlessApply build --console=plain through the build-slot script; counts summed over build/test-results/test/TEST-*.xml:

commit result files tests failures errors skipped
before 0109bcb (develop) 29 160 0 0 0
test e716281 29 161 0 0 0
Map.Entry 1865131 29 161 0 0 0
7.0 f03ce9d 29 161 0 0 0

git grep -n "silly.bean\|silly-bean\|KeyValuePair" -- src gradle build.gradle on 1865131: nothing.

…ir today (#53)

PropertiesListResolver hands out its result as List<KeyValuePair<File,
Locale>>, a type of silly-bean, which is archived (astrapi69/silly-bean#37).
Its getter moves to the JDK's Map.Entry in the next commit. No test read
the list so far: the two tests check the constructor only.

The test builds a tree at runtime and pins what resolve() finds: each
properties file, also in a subdirectory, with the locale of its name
(messages_de to German, messages_de_DE to Germany), the default locale for
a file without one, and no entry for a file of another kind. It reads the
entries through the element type of today, so the next commit shows the
change of the getter's type in this test.
…lly-bean goes (#53)

silly-bean is archived (astrapi69/silly-bean#37): the JDK covers what it
was for, and its users migrate in their own repositories. This repository
used it in one place: PropertiesListResolver kept its result as
List<KeyValuePair<File, Locale>>, which Lombok's @Getter makes public as
getPropertiesList().

The list holds Map.Entry<File, Locale> now, each an
AbstractMap.SimpleImmutableEntry, as the library rule takes the JDK first;
unlike Map.entry it does not refuse a null value. getKey() and getValue()
stay as they were, so a caller changes only the element type it names. The
direct dependency on silly-bean goes from dependencies.gradle, the version
catalog and module-info.java. silly-bean 2 stays on the runtime class path
through silly-collection 28 and file-worker 17.4 until those are raised.

BREAKING CHANGE: getPropertiesList() returns List<Map.Entry<File, Locale>>
instead of List<KeyValuePair<File, Locale>>.
getPropertiesList() of PropertiesListResolver changes its type with the
commit before, a change of the public API, so the next release is a major
(RL-060), not 6.2. The form follows the last major of this repository,
6.0.

Closes #53
@codecov

codecov Bot commented Nov 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.81%. Comparing base (0109bcb) to head (f03ce9d).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #57      +/-   ##
=============================================
- Coverage      74.84%   74.81%   -0.04%     
  Complexity       205      205              
=============================================
  Files             25       25              
  Lines            831      830       -1     
  Branches         140      140              
=============================================
- Hits             622      621       -1     
  Misses           130      130              
  Partials          79       79              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astrapi69
astrapi69 merged commit 956efce into develop Nov 7, 2026
9 checks passed
@astrapi69
astrapi69 deleted the chore/53-drop-silly-bean branch November 7, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

silly-bean is archived: PropertiesListResolver hands out KeyValuePair

1 participant