fix(OUT-4107): await SWR mutate refetches and enrich fetcher errors - #1436
Closed
cursor[bot] wants to merge 1 commit into
Closed
fix(OUT-4107): await SWR mutate refetches and enrich fetcher errors#1436cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Unawaited mutate() calls after optimistic comment, subtask, and subtemplate creation let post-mutation fetcher failures surface as unhandled rejections in Sentry. Await those mutations and include HTTP status, URL, and response body in fetcher errors to make future triage actionable. Co-authored-by: Neil Raina <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
mutate()calls inActivityWrapper,Subtasks, andSubtemplatesso post-mutationfetcher()failures are caught by existingtry/catchblocks instead of surfacing as unhandled promise rejections in Sentry.src/utils/fetcher.tserrors with HTTP status, request URL, and truncated response body so future Sentry events are actionable.fetcher.Testing Criteria
yarn test src/utils/fetcher.test.ts— 3/3 passed.handleDeleteComment,handleSubTaskUpdate,ArchiveWrapper) which alreadyawait mutate().Notes
Error: An error occurred while fetching the data.matches the generic message thrown bysrc/utils/fetcher.tswhen an API returns a non-OK response.Impact & Surface Area of Change