fix localstorage access - #1435
Merged
Merged
Conversation
…1397) deleteLabel passed `id: currentLabel?.id` straight into label.delete, so when findFirst matched nothing Prisma got `{ id: undefined }` and threw PrismaClientValidationError, failing the whole delete transaction. Return early instead.
* OUT-4093 | Remove the localStorage→localForage assignee migration
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SandipBajracharya
approved these changes
Aug 24, 2026
Contributor
|
Deployment failed for project tasks-app with the following error: Learn More: https://vercel.link/multiple-function-regions |
Greptile SummaryThis PR makes the assignee cache tolerate unavailable browser storage and makes label deletion safely no-op when its mapping is absent.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. Storage failures degrade to the existing authoritative network assignee fetch, while the label guard safely preserves idempotent cleanup when no active mapping exists. Important Files Changed
Reviews (1): Last reviewed commit: "OUT-4093 | Stop reading localStorage in ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria
Notes
Impact & Surface Area of Change