Restore Retry Now socket subscription - #14
Merged
Merged
Conversation
## Why Retry Now opens the Socket.IO manager directly after some disconnect paths have removed the namespace subscriptions. The transport can reopen without restoring the page socket, leaving the unavailable state visible. ## What changed - Reconnect through the Socket so namespace subscriptions are restored before the manager opens. - Preserve continuous backoff and access-token recovery for failed retry attempts. ## Testing Covered offline automatic recovery, immediate recovery after a full Socket disconnect, current-token recovery, and the complete browser regression suite.
## Why Browser authorization setup documents the redemption flow but not the grant link's bearer scope, persistent browser trust, or process-lifetime access token. Forwarding one of these credentials can therefore grant more access than its holder expects. ## What changed - Document the local minting boundary and the authorization URL's single-use 120-second lifetime. - Explain that accepted browser keys remain authorized until revoked. - Preserve the existing process-scoped access token behavior while documenting its rotation condition. ## Testing Covered source-level verification of authorization grant expiry and replay rejection, local HTTP minting policy, persistent browser-key storage, and process-scoped access token generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Retry Now opens the Socket.IO manager directly after some disconnect paths have removed the namespace subscriptions. The transport can reopen without restoring the page socket, while the README also leaves the browser-owned SSH signer advantages and browser authorization credential scope implicit.
What changed
Testing
Covered offline automatic recovery, immediate recovery after a full Socket disconnect, current-token recovery, the complete browser regression suite, backend authorization and SSH signer policy scenarios, and static documentation validation.