Repository navigation
V1.1 blocker: fix target-machine QML startup failure - #91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lineHeightassignment from theTextEditinGitDiffPanel.qmlApplicationStartupSmoke.shthat instantiates the real root QML underQT_QPA_PLATFORM=offscreenTarget-machine failure fixed
Exact candidate
8f82b5c5ccfbea03babb67244b3e42baa43d4ad4passed 29/29 main tests and 4/4 preview tests but failed at real launch with:The root cause is the
TextEdit.lineHeightassignment inGitDiffPanel.qml. Removing it preserves the bounded diff viewer and allows the component chain to instantiate on the target Qt runtime.Validation policy
Frozen head:
868f3e6b6d99442bc5b6bc265da03ff4140da8a5Base:
8f82b5c5ccfbea03babb67244b3e42baa43d4ad4Merge only if Build and Packaging are green on this exact head. After merge, target-machine validation must restart from the new
mainSHA; evidence from8f82b5c5…is superseded.Closes #90.
Blocks #72 and #69 until target-machine retest passes.