Remove 'all' extra - #54
Merged
Merged
Conversation
reweeden
force-pushed
the
rew/remove-all-extra
branch
2 times, most recently
from
August 26, 2026 21:34
a973b00 to
0b6850a
Compare
reweeden
force-pushed
the
rew/remove-all-extra
branch
from
August 26, 2026 21:36
0b6850a to
907f36a
Compare
reweeden
marked this pull request as ready for review
August 26, 2026 21:44
reweeden
requested review from
Cameronsplaze,
benbart,
gjclark and
mckadesorensen
August 26, 2026 21:45
mckadesorensen
approved these changes
Aug 27, 2026
gjclark
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'all' extra was meant to be a convenience but turned out to be a maintenance headache, getting copied and pasted around for workflows that then pull in dependencies that they don't actually need or use. Plus, as new dependencies are added to the
allextra, even existing workflows that did needallbefore now suddenly pull in additional unnecessary dependencies.I believe it is best to remove
alland require workflows to enumerate exactly the extras that they need going forward to reduce confusion and make it easier to see what components are actually used when looking through requirements files.Request Checklist
I have: