Refine GDAL export dialog options section. - #2758
Open
lllarsen wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Two pieces of feedback I would like: The output filename updating logic uses untracked in an effect to ensure that the output filename only updates when a new dataset is selected, instead of updating anytime gdal options are changed. This creates confusion of causality however, it would be much better executed with some api which triggers a function when a specific signal updates instead of as an effect, however I'm not sure if that is possible in angular. Also, for some reason I can only update the outputFilename signal by setting it to an empty string first. No clue why that happens, would love some insight on that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds subsections to GDAL export dialog and adds the ability it input arbitrary cutline WKT strings. Fixes output filename not updating when new datasets are selected.
Screenshots / UI Changes
i18n
i18n keys changed/added
Tests & Build
npm run lintpassesnpm testpasses (or N/A)npm run buildsucceeds