Skip to content

Refine GDAL export dialog options section. - #2758

Open
lllarsen wants to merge 3 commits into
testfrom
lily/gdal-export-fixes
Open

Refine GDAL export dialog options section.#2758
lllarsen wants to merge 3 commits into
testfrom
lily/gdal-export-fixes

Conversation

@lllarsen

@lllarsen lllarsen commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds subsections to GDAL export dialog and adds the ability it input arbitrary cutline WKT strings. Fixes output filename not updating when new datasets are selected.

Screenshots / UI Changes

image

i18n

  • No hardcoded user-facing strings
  • New or modified translation keys are documented below

i18n keys changed/added

  • KEY_PATH_ONE –
  • KEY_PATH_TWO –

Tests & Build

  • npm run lint passes
  • npm test passes (or N/A)
  • npm run build succeeds

@lllarsen
lllarsen requested a review from a team as a code owner September 5, 2026 00:23
@lllarsen

lllarsen commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Two pieces of feedback I would like:

The output filename updating logic uses untracked in an effect to ensure that the output filename only updates when a new dataset is selected, instead of updating anytime gdal options are changed. This creates confusion of causality however, it would be much better executed with some api which triggers a function when a specific signal updates instead of as an effect, however I'm not sure if that is possible in angular.

Also, for some reason I can only update the outputFilename signal by setting it to an empty string first. No clue why that happens, would love some insight on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant