fix(memory): preserve existing DB when sqlite3_open fails - #63
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(memory): preserve existing DB when sqlite3_open fails#63cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Do not unlink an existing memory.db on transient open failures (permissions, I/O). Deleting the file caused silent data loss when init was retried after the underlying issue cleared. Adds test_existing_db_preserved_on_open_failure. Co-authored-by: esadrianno <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents silent data loss when
memory_initcannot open an existing SQLite database.Bug and impact
On
sqlite3_openfailure,memory_initcalledremove(path)before retrying. If the DB file already existed (permissions blip, transient I/O), the on-disk memory store was deleted and replaced with an empty database on retry — losing sessions, long-term memories, and cron jobs.Root cause
Open-failure recovery treated existing and missing files the same: unlink then recreate.
Fix and validation
remove()when the path already existed; return error instead.test_existing_db_preserved_on_open_failure(chmod 000 → init fails → data intact after restore)../build/test_memory— all tests pass.