fix(webchat): align WebSocket payload limit with agent response buffer - #62
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(webchat): align WebSocket payload limit with agent response buffer#62cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Raise WS_TEXT_MAX to 32KiB to match dispatch RESPONSE_BUF_SIZE so agent replies between 8KiB and 32KiB are delivered instead of silently dropped. Co-authored-by: esadrianno <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
WebChat silently dropped agent replies larger than 8KiB.
dispatch.cfills a 32KiB buffer butws_send_torejected payloads above 8192 bytes with no error surfaced to the user.Impact
Dashboard/WebChat users saw no response for typical tool-heavy or long agent output.
Fix
WS_TEXT_MAX(32KiB) inws.h, aligned withRESPONSE_BUF_SIZEws.c,http_lws.c, andwebchat.cValidation
make test_ws(all tests pass)