fix(sdk): match Windows runtime archive name on npm publish - #1217
Conversation
The first runtime publish looked for ade-win32-x64.exe.native.tar.gz. Releases publish ade-win32-x64.native.tar.gz, so checksum verification stopped at 9 of 10 files. Co-authored-by: Cursor <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f6078f9b-029f-4ffa-9328-5be5855ac770) |
A real v1.2.72 native listing overflows Node's 1 MiB execFileSync default, so the publish job died with ENOBUFS after checksums already passed. Co-authored-by: Cursor <[email protected]>
Problem
The first
Publish ADE runtime packagesrun againstv1.2.72failed at checksum verification: it expected 10 runtime SHA256SUMS lines and found 9.Cause
runtimeAssetNames("win32-x64")and the workflow grep looked forade-win32-x64.exe.native.tar.gz. Releases and SHA256SUMS publishade-win32-x64.native.tar.gz(the.exeis only on the launcher).Change and boundary
The helper now returns the real Windows archive name. The checksum step reads those names from the helper instead of a second grep. No packages were published by the failed run.
Verification
node --test apps/ade-cli/scripts/build-runtime-npm-packages.test.mjs apps/ade-cli/scripts/verify-runtime-package-contents.test.mjs: 41 passedv1.2.72SHA256SUMS runtime linesAuthored with Cursor Grok 4.6 via ADE.
Made with Cursor