Skip to content

fix(sdk): match Windows runtime archive name on npm publish - #1217

Merged
arul28 merged 2 commits into
mainfrom
fix/runtime-win32-native-archive-name
Sep 2, 2026
Merged

fix(sdk): match Windows runtime archive name on npm publish#1217
arul28 merged 2 commits into
mainfrom
fix/runtime-win32-native-archive-name

Conversation

@arul28

@arul28 arul28 commented Sep 2, 2026

Copy link
Copy Markdown
Owner

Problem

The first Publish ADE runtime packages run against v1.2.72 failed at checksum verification: it expected 10 runtime SHA256SUMS lines and found 9.

Cause

runtimeAssetNames("win32-x64") and the workflow grep looked for ade-win32-x64.exe.native.tar.gz. Releases and SHA256SUMS publish ade-win32-x64.native.tar.gz (the .exe is only on the launcher).

Change and boundary

The helper now returns the real Windows archive name. The checksum step reads those names from the helper instead of a second grep. No packages were published by the failed run.

Verification

  • node --test apps/ade-cli/scripts/build-runtime-npm-packages.test.mjs apps/ade-cli/scripts/verify-runtime-package-contents.test.mjs: 41 passed
  • Helper matched all 10 v1.2.72 SHA256SUMS runtime lines

Authored with Cursor Grok 4.6 via ADE.

Made with Cursor

The first runtime publish looked for ade-win32-x64.exe.native.tar.gz. Releases publish ade-win32-x64.native.tar.gz, so checksum verification stopped at 9 of 10 files.

Co-authored-by: Cursor <[email protected]>
@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
ade Ignored Ignored Preview Sep 2, 2026 4:52pm UTC

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 10da887f-4c4b-41b6-b3ed-9085383c0067

📥 Commits

Reviewing files that changed from the base of the PR and between 234df59 and 98df7d5.

📒 Files selected for processing (3)
  • .github/workflows/publish-runtime-packages.yml
  • apps/ade-cli/scripts/build-runtime-npm-packages.mjs
  • apps/ade-cli/scripts/build-runtime-npm-packages.test.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_f6078f9b-029f-4ffa-9328-5be5855ac770)

A real v1.2.72 native listing overflows Node's 1 MiB execFileSync default, so the publish job died with ENOBUFS after checksums already passed.

Co-authored-by: Cursor <[email protected]>
@arul28
arul28 merged commit 2715af7 into main Sep 2, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant