Strip comma instead of keyboard-adjacent m when compacting CID - #508
Closed
holvitolv wants to merge 2 commits into
Closed
Strip comma instead of keyboard-adjacent m when compacting CID#508holvitolv wants to merge 2 commits into
holvitolv wants to merge 2 commits into
Conversation
holvitolv
force-pushed
the
eu-at-02-misprint
branch
from
August 12, 2026 00:25
b7fa9ec to
4046b3d
Compare
Owner
|
Hi @holvitolv, Thanks for fixing this. It has been merged as 30aaa38. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does look like once upon a 2014 the author of stdnum.eu.at_02 hit
mwhen intending to hit,while typing the list of characters to strip from CIDs, as the documentation for it offers no more plausible theories that I can tell, no special meaning is given to anmorMor their complement there :DE.g. the Maltese example MT50ZZZ670169305T from the documentation, if provided in lowercase, would lose its M in compacting, as demonstrated by the test in the first commit. Strip the keyboard-adjacent punctuation instead.