Skip to content

fix(quickshape): preserve freehand curves, reject false arcs, and speed up editing - #246

Open
wesleydanieell wants to merge 15 commits into
artcraft-android:mainfrom
wesleydanieell:fix/quickshape-smooth-curves
Open

wesleydanieell wants to merge 15 commits into
artcraft-android:mainfrom
wesleydanieell:fix/quickshape-smooth-curves

Conversation

@wesleydanieell

Copy link
Copy Markdown
Contributor

Summary

  • Enable bundled QuickShape Curves by default for new installs and for existing Android installs without a saved choice, respecting user preferences.
  • Fit held freehand strokes as cubic Bézier curves with bounded deviation, bounded sample counts, smoothing that keeps sharp corners, and independent controls for intentional turns.
  • Tighten arc recognition: preserve S-shaped bends, local deviations and small intentional changes near stroke endings instead of distorting them into ellipses; use circular fitting when more faithful.
  • Fix anchor editing: moving a Bézier anchor moves its adjacent controls (including the seam of a closed curve).
  • Improve responsiveness while editing long curves using adaptive Bézier subdivision instead of 128 outline samples per segment.
  • Bundle QuickShape Curves 1.2.8 with updated metadata and source hash; limit WASM fitting work so dense stylus input does not disable the plugin.
  • Update desktop plugin tests to reflect the new default while preserving explicit on/off and removal behavior; clean up safe indexing and comments.

Validation

  • cargo fmt --all -- --check — passed.
  • cargo clippy --workspace --all-targets -- -D warnings — passed.
  • cargo clippy --manifest-path plugins/quickshape-curves/Cargo.toml --all-targets -- -D warnings — passed.
  • cargo test --manifest-path plugins/quickshape-curves/Cargo.toml --quiet — 14 passed.
  • cargo test --workspace --quiet — core and other suites passed; a pre-existing desktop expectation about bundled plugins being disabled was found and corrected. The targeted replacement desktop test passed.
  • Android debug builds for ARM64 and x86_64 were installed and manually reviewed on Redmi Pad 2 and Small Tablet emulator.

Notes

  • For ambiguous arc-like input, this intentionally prefers preserving the freehand line over replacing it with an inaccurate ellipse.
  • All commits carry Co-authored-by: Codex <[email protected]>.

wesleydanieell and others added 15 commits November 16, 2026 22:49
Address strict Clippy indexing warnings in curve editing and arc fitting, and refresh the bundled curve plugin documentation and digest.

Co-authored-by: Codex <[email protected]>
bearinmindcat added a commit that referenced this pull request Nov 17, 2026
… dragged takes its controls along, and long curves edit faster (#246)


Co-authored-by: Wesley <[email protected]>
@bearinmindcat

Copy link
Copy Markdown
Contributor

c07cf7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants