fix: Apps.ZKVoting.Prover ignored test - #517
Merged
Merged
Conversation
samuelburnham
force-pushed
the
sb/fix-zkvoting-commit-resolution
branch
from
July 24, 2026 17:10
d0d4c4d to
933983b
Compare
samuelburnham
changed the title
#509 split CompileEnv name resolution — nameToAddr became the authority consulted by lookupConstAddr, seeded in mkCompileEnv — but commitDef was not updated and kept registering commitments only in nameToNamed (the final named registry, not the resolution map). Referencing a committed constant then failed with `missingConstant`, breaking Apps.ZKVoting.Prover. Also insert into nameToAddr so committed constants resolve.
samuelburnham
force-pushed
the
sb/fix-zkvoting-commit-resolution
branch
from
July 24, 2026 19:27
933983b to
fd55a48
Compare
samuelburnham
marked this pull request as ready for review
July 24, 2026 19:28
samuelburnham
enabled auto-merge (squash)
July 24, 2026 19:28
arthurpaulino
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#509 split CompileEnv name resolution — nameToAddr became the authority consulted by lookupConstAddr, seeded in mkCompileEnv — but commitDef was not updated and kept registering commitments only in nameToNamed (the final named registry, not the resolution map). Referencing a committed constant then failed with
missingConstant, breaking Apps.ZKVoting.Prover. Also insert into nameToAddr so committed constants resolve.Successful run: https://github.com/argumentcomputer/ix/actions/runs/30111995374/job/89543507174