test(elevenlabs): fix flaky stream_abort_mid_session - #199
Merged
Merged
Conversation
stream_abort_mid_session started its 100ms abort timer before do_stream. On a slow runner the abort fired during the connect, do_stream returned Aborted, and the unwrap panicked (seen on #197's CI). Start the timer once the session is up so the abort is always mid-session. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_abort_mid_sessionarmed its 100ms abort timer beforedo_stream. On a slow CI runner the abort fired during the WebSocket connect,do_streamitself returnedAborted("request aborted"), and the.unwrap()at line 484 panicked — seen on #197's Rust core job (a docs-only PR; a re-run passed).The timer now starts after
do_streamreturns, so the abort always lands mid-session, which is what the test is named for.Test plan
cargo test -p aimux-providers --test elevenlabs_realtime_stream_test— 8 passedcargo fmt --check🤖 Generated with Claude Code