Repository navigation
docs: recommend max_completion_tokens - #27
Merged
Merged
Conversation
- Recommend the completion token setting across all README translations - Clarify precedence, legacy compatibility, and reasoning-model conversion
- Align input headers and completion token rows in both Chinese translations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recommend
max_completion_tokens: "2000"for new configurations in the English, Traditional Chinese, and Simplified Chinese READMEs. Explain precedence overmax_tokens, continued support for legacy services, and automatic conversion for recognized reasoning models when the new input is unset.Change classification and scope
AI authorship
README.md,README.zh-TW.md,README.zh-CN.md.Verification
Prerequisites: Git and a text editor; check out
docs/recommend-max-completion-tokensand run commands from the repository root. No services or credentials are required.buildChatRequestandreasoningModelPrefixesinmain.go. Expect explicit completion tokens to win, recognized reasoning models to convert the legacy field when unset, and other models to retain the legacy field. Passed: inspected the existing implementation and confirmed the documented behavior.git diff origin/main...HEAD --check. Expect exit status 0 and no whitespace errors. Passed before commit:git diff --checkandgit diff --staged --checkboth exited 0 with no output.Runtime tests, build, and Go/Docker linters: Not run because only Markdown prose and an example were added; no executable code or build configuration changed. No Markdown-specific check is configured in the repository.
Cleanup: none; inspection does not create data.
Risk and review
main.go.