Skip to content

Finish the renames and derive every add-on name from its directory - #91

Merged
hal-eisen-adfa merged 2 commits into
mainfrom
rename-voice-alerts-rainbow-brackets
Sep 8, 2026
Merged

Finish the renames and derive every add-on name from its directory#91
hal-eisen-adfa merged 2 commits into
mainfrom
rename-voice-alerts-rainbow-brackets

Conversation

@hal-eisen-adfa

@hal-eisen-adfa hal-eisen-adfa commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Why

The Publish addons run summary still showed old names. That table is the Gradle setup-gradle job summary, and its Gradle Root Project column prints rootProject.name — which nothing had ever been derived from the directory.

docs/plugin-naming-standards.md makes the plugins/ directory the single source of truth and says generic type-words ("plugin", "CGP", "Documentation") do not belong in a name. The directories already comply. rootProject.name did not.

Commit 1 — finish the Voice Alerts and Rainbow Brackets renames

The earlier rename changed the directory names and plugin.name, and stopped there.

Old New
com.example.beepy org.appdevforall.voicealerts
Beepy (class) VoiceAlertsPlugin
org.appdevforall.rainbowonthego org.appdevforall.rainbowbrackets
RainbowOnTheGoPlugin RainbowBracketsPlugin

Applied to plugin.id, applicationId, namespace, the Kotlin package directories, class names, android:label, app_name, proguard keep rules, both READMEs, both add-on HTML pages, and the Rainbow Brackets Tier 3 help page and tooltip text.

Also fixed: RainbowBracketsPlugin.getTooltipCategory() returned the hand-written "plugin_rainbow_on_the_go" instead of "plugin_" + plugin.id. Per CLAUDE.md that mismatch makes the tooltip render the literal n/a. It now derives from PLUGIN_ID.

Commit 2 — derive rootProject.name for all 22 add-ons

code-suggestions-plugin -> code-suggestions
fluttertemplate         -> flutter-templates
GetAiModelsPlugin       -> get-ai-models
IconsRepository-Plugin  -> icons-repository
compose-preview         -> jetpack-compose-preview
ndk-installer-plugin    -> ndk-installer
sketch-to-ui-plugin     -> sketch-to-ui
speech-to-text-plugin   -> speech-to-text
vector-search-plugin    -> vector-search

Plus the places that quoted those stale names: README build instructions naming .cgp files the build never produced, cd <old-name> lines, dead ai-core links into sibling directories that no longer exist, and the Icons Repository display name in its manifest label, README heading and add-on page.

Left alone on purpose:

  • Upstream GitHub URLs for the Icons Repository attribution keep the original repository name.
  • Kotlin class names keep the ...Plugin suffix. They are code identifiers, not the add-on's name, and 18 of 22 add-ons already use it.

Breaking

plugin.id changes for Voice Alerts and Rainbow Brackets, so the Plugin Manager sees new add-ons. An existing install does not upgrade in place — it must be removed and reinstalled.

Verification

  • addons check passes. check-toolchain.sh passes.
  • Clean assemblePlugin for Voice Alerts, Rainbow Brackets and Icons Repository. Packaged manifests confirmed with aapt2 dump xmltree:
    • voice-alerts.cgppackage=org.appdevforall.voicealerts, plugin.main_class=org.appdevforall.voicealerts.VoiceAlertsPlugin, label Voice Alerts, three WAVs and both icons present.
    • rainbow-brackets.cgppackage=org.appdevforall.rainbowbrackets, plugin.main_class=org.appdevforall.rainbowbrackets.RainbowBracketsPlugin, assets/docs/index.html and both icons present.
  • Not device-verified. The tooltip-category fix in particular only shows up on a device long-press, so it needs an install before that part is trusted.

https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ

The earlier rename changed the directories and plugin.name but left the
package identity and every prose string alone. The Gradle job summary in
the Publish addons workflow reports rootProject.name, so it still listed
"Beepy" and "rainbow-on-the-go" after a publish.

Rename both add-ons end to end:

  com.example.beepy               -> org.appdevforall.voicealerts
  Beepy                           -> VoiceAlertsPlugin
  org.appdevforall.rainbowonthego -> org.appdevforall.rainbowbrackets
  RainbowOnTheGoPlugin            -> RainbowBracketsPlugin

This covers plugin.id, applicationId, namespace, the Kotlin package
directories, class names, rootProject.name, android:label, app_name,
proguard keep rules, both READMEs, both add-on HTML pages, and the
Rainbow Brackets Tier 3 help page and tooltip text.

Also fix getTooltipCategory() in Rainbow Brackets, which returned the
hand-written "plugin_rainbow_on_the_go" instead of "plugin_" plus the
plugin id. Per CLAUDE.md that mismatch makes the tooltip render "n/a".
It now derives from PLUGIN_ID.

Breaking: plugin.id changes, so the Plugin Manager treats these as new
add-ons. An existing install does not upgrade in place; it must be
removed and reinstalled.

Claude-Session: https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

docs/plugin-naming-standards.md makes the plugins/ directory name the
single source of truth and says generic type-words ("plugin", "CGP",
"Documentation") do not belong in a name. The directories already comply.
rootProject.name did not, and it is what the Gradle job summary prints as
"Gradle Root Project" in the Publish addons run.

Set rootProject.name to the lowercased directory name for all 22 add-ons:

  code-suggestions-plugin -> code-suggestions
  fluttertemplate         -> flutter-templates
  GetAiModelsPlugin       -> get-ai-models
  IconsRepository-Plugin  -> icons-repository
  compose-preview         -> jetpack-compose-preview
  ndk-installer-plugin    -> ndk-installer
  sketch-to-ui-plugin     -> sketch-to-ui
  speech-to-text-plugin   -> speech-to-text
  vector-search-plugin    -> vector-search

Also correct the places that quoted those stale names: README build
instructions naming .cgp files that the build never produced
(speech-to-text-plugin.cgp, vector-search-plugin.cgp,
code-suggestions-plugin.cgp, IconsRepository-Plugin.cgp,
fluttertemplate.cgp), "cd <old-name>" lines, dead ai-core links into
sibling directories that no longer exist, and the Icons Repository
display name in its manifest label, README heading and add-on page.

Upstream GitHub URLs for the Icons Repository attribution keep the
original repository name. Kotlin class names keep the ...Plugin suffix:
they are code identifiers, not the add-on's name, and 18 of 22 add-ons
already use it.

Claude-Session: https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ
@hal-eisen-adfa hal-eisen-adfa changed the title Finish the Voice Alerts and Rainbow Brackets renames Finish the renames and derive every add-on name from its directory Sep 8, 2026
@hal-eisen-adfa
hal-eisen-adfa merged commit 698c606 into main Sep 8, 2026
1 check passed
@hal-eisen-adfa
hal-eisen-adfa deleted the rename-voice-alerts-rainbow-brackets branch September 8, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant