Finish the renames and derive every add-on name from its directory - #91
Merged
Conversation
The earlier rename changed the directories and plugin.name but left the package identity and every prose string alone. The Gradle job summary in the Publish addons workflow reports rootProject.name, so it still listed "Beepy" and "rainbow-on-the-go" after a publish. Rename both add-ons end to end: com.example.beepy -> org.appdevforall.voicealerts Beepy -> VoiceAlertsPlugin org.appdevforall.rainbowonthego -> org.appdevforall.rainbowbrackets RainbowOnTheGoPlugin -> RainbowBracketsPlugin This covers plugin.id, applicationId, namespace, the Kotlin package directories, class names, rootProject.name, android:label, app_name, proguard keep rules, both READMEs, both add-on HTML pages, and the Rainbow Brackets Tier 3 help page and tooltip text. Also fix getTooltipCategory() in Rainbow Brackets, which returned the hand-written "plugin_rainbow_on_the_go" instead of "plugin_" plus the plugin id. Per CLAUDE.md that mismatch makes the tooltip render "n/a". It now derives from PLUGIN_ID. Breaking: plugin.id changes, so the Plugin Manager treats these as new add-ons. An existing install does not upgrade in place; it must be removed and reinstalled. Claude-Session: https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
docs/plugin-naming-standards.md makes the plugins/ directory name the
single source of truth and says generic type-words ("plugin", "CGP",
"Documentation") do not belong in a name. The directories already comply.
rootProject.name did not, and it is what the Gradle job summary prints as
"Gradle Root Project" in the Publish addons run.
Set rootProject.name to the lowercased directory name for all 22 add-ons:
code-suggestions-plugin -> code-suggestions
fluttertemplate -> flutter-templates
GetAiModelsPlugin -> get-ai-models
IconsRepository-Plugin -> icons-repository
compose-preview -> jetpack-compose-preview
ndk-installer-plugin -> ndk-installer
sketch-to-ui-plugin -> sketch-to-ui
speech-to-text-plugin -> speech-to-text
vector-search-plugin -> vector-search
Also correct the places that quoted those stale names: README build
instructions naming .cgp files that the build never produced
(speech-to-text-plugin.cgp, vector-search-plugin.cgp,
code-suggestions-plugin.cgp, IconsRepository-Plugin.cgp,
fluttertemplate.cgp), "cd <old-name>" lines, dead ai-core links into
sibling directories that no longer exist, and the Icons Repository
display name in its manifest label, README heading and add-on page.
Upstream GitHub URLs for the Icons Repository attribution keep the
original repository name. Kotlin class names keep the ...Plugin suffix:
they are code identifiers, not the add-on's name, and 18 of 22 add-ons
already use it.
Claude-Session: https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
Publish addonsrun summary still showed old names. That table is the Gradlesetup-gradlejob summary, and its Gradle Root Project column printsrootProject.name— which nothing had ever been derived from the directory.docs/plugin-naming-standards.mdmakes theplugins/directory the single source of truth and says generic type-words ("plugin", "CGP", "Documentation") do not belong in a name. The directories already comply.rootProject.namedid not.Commit 1 — finish the Voice Alerts and Rainbow Brackets renames
The earlier rename changed the directory names and
plugin.name, and stopped there.com.example.beepyorg.appdevforall.voicealertsBeepy(class)VoiceAlertsPluginorg.appdevforall.rainbowonthegoorg.appdevforall.rainbowbracketsRainbowOnTheGoPluginRainbowBracketsPluginApplied to
plugin.id,applicationId,namespace, the Kotlin package directories, class names,android:label,app_name, proguard keep rules, both READMEs, both add-on HTML pages, and the Rainbow Brackets Tier 3 help page and tooltip text.Also fixed:
RainbowBracketsPlugin.getTooltipCategory()returned the hand-written"plugin_rainbow_on_the_go"instead of"plugin_" + plugin.id. Per CLAUDE.md that mismatch makes the tooltip render the literaln/a. It now derives fromPLUGIN_ID.Commit 2 — derive
rootProject.namefor all 22 add-onsPlus the places that quoted those stale names: README build instructions naming
.cgpfiles the build never produced,cd <old-name>lines, deadai-corelinks into sibling directories that no longer exist, and the Icons Repository display name in its manifest label, README heading and add-on page.Left alone on purpose:
...Pluginsuffix. They are code identifiers, not the add-on's name, and 18 of 22 add-ons already use it.Breaking
plugin.idchanges for Voice Alerts and Rainbow Brackets, so the Plugin Manager sees new add-ons. An existing install does not upgrade in place — it must be removed and reinstalled.Verification
addons checkpasses.check-toolchain.shpasses.assemblePluginfor Voice Alerts, Rainbow Brackets and Icons Repository. Packaged manifests confirmed withaapt2 dump xmltree:voice-alerts.cgp—package=org.appdevforall.voicealerts,plugin.main_class=org.appdevforall.voicealerts.VoiceAlertsPlugin, labelVoice Alerts, three WAVs and both icons present.rainbow-brackets.cgp—package=org.appdevforall.rainbowbrackets,plugin.main_class=org.appdevforall.rainbowbrackets.RainbowBracketsPlugin,assets/docs/index.htmland both icons present.https://claude.ai/code/session_016aaKF7nPCSrLe7oZ5DTHLZ