K2GO-394 fix(maps): remove the dead is_proot RPC download patch - #563
Merged
Conversation
0003-maps-download-is-proot-rpc.patch is leftover from the abandoned aria2 RPC approach: it splits the maps download task by is_proot and gives the proot variant --enable-rpc, which is exactly the flag that wedged aria2 at zero connections (the reason the approach was dropped). It reached main with the app PR's RPC-era history. The shipped design downloads base maps through dash-node ahead of the runrole and leaves the maps role stock -- its native creates: skips the pre-placed files -- so there is intentionally no maps role patch (see controller/docs/ADR-K2GO-394-maps-download-via-dashnode.md and the upstream-patches README). Applying this dead patch in the rootfs bake would re-patch the role with the retired RPC variant, so remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0003-maps-download-is-proot-rpc.patch is leftover from the abandoned aria2 RPC approach: it splits the maps download task by is_proot and gives the proot variant --enable-rpc, which is exactly the flag that wedged aria2 at zero connections (the reason the approach was dropped). It reached main with the app PR's RPC-era history.
The shipped design downloads base maps through dash-node ahead of the runrole and leaves the maps role stock -- its native creates: skips the pre-placed files -- so there is intentionally no maps role patch (see
controller/docs/ADR-K2GO-394-maps-download-via-dashnode.md and the upstream-patches README). Applying this dead patch in the rootfs bake would re-patch the role with the retired RPC variant, so remove it.