Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
234 commits
Select commit Hold shift + click to select a range
34bd629
style: spotless reformat, no functional change
davidschachterADFA Sep 4, 2026
20b0c46
fix: stop SwipeRevealLayout's right drag helper capturing every child
davidschachterADFA Sep 4, 2026
9cd2750
refactor: extract MemoryUsageChartRenderer, render from watcher history
davidschachterADFA Sep 4, 2026
fc4bc26
feat: make the editor's memory chart a carousel of metric displays
davidschachterADFA Sep 4, 2026
f4f678a
feat: let the metrics carousel own horizontal swipes in its own strip
davidschachterADFA Sep 4, 2026
ddee12e
feat: replace the carousel's dot indicator with a page title
davidschachterADFA Sep 4, 2026
7becd06
feat: add a UID-level network traffic page to the metrics carousel
davidschachterADFA Sep 4, 2026
d668f78
fix: label the network axis in whole units and rest zero on the baseline
davidschachterADFA Sep 4, 2026
cf90aaf
fix: honour MemoryUsageWatcher's configured sampling interval
davidschachterADFA Sep 5, 2026
d7b34a6
refactor: extract MetricsChartRenderer, shared by both carousel charts
davidschachterADFA Sep 5, 2026
e681aa5
feat: retain an hour of samples, in a ViewModel, shown as a moving wi…
davidschachterADFA Sep 5, 2026
6e5e2a2
fix: make the x axis labels visible, and sample while backgrounded
davidschachterADFA Sep 5, 2026
bd4f2b5
feat: raise retention to 10000 samples and add the sampling-rate policy
davidschachterADFA Sep 5, 2026
d551fdc
refactor: extract MetricsCarouselController ahead of undocking
davidschachterADFA Sep 5, 2026
6108434
feat: undock the metrics carousel into a floating window
davidschachterADFA Sep 5, 2026
33d3b4a
Merge branch 'stage' into feature/ADFA-5487-metrics-carousel
davidschachterADFA Sep 5, 2026
d74b19f
Merge branch 'feature/ADFA-5487-metrics-carousel' into feature/ADFA-5…
davidschachterADFA Sep 5, 2026
78ef79b
fix: make the sampling loop stoppable, restartable and crash-proof
davidschachterADFA Sep 5, 2026
ebe6874
feat: annotate the metrics charts with Gradle task events
davidschachterADFA Sep 5, 2026
f632892
feat: export a chart snapshot as a shareable image
davidschachterADFA Sep 5, 2026
1e36e1d
feat: choose the sampling rate by tapping the x axis
davidschachterADFA Sep 5, 2026
f5f2d7d
feat: trigger the chart snapshot from a camera button
davidschachterADFA Sep 5, 2026
61d1131
feat: pinch to zoom the chart, with the carousel swipe kept below the…
davidschachterADFA Sep 5, 2026
825ee45
fix: restore the carousel swipe and the auto-follow window; add pagin…
davidschachterADFA Sep 5, 2026
7511b17
fix: tint the carousel arrows so they are visible on a dark chart
davidschachterADFA Sep 5, 2026
9444417
feat: page the carousel only with the arrows
davidschachterADFA Sep 5, 2026
2a72a8a
Merge branch 'feature/ADFA-5489-network-traffic-page' into feature/AD…
davidschachterADFA Sep 5, 2026
ccc3ae2
feat(metrics): add a temperature and power page to the carousel (ADFA…
davidschachterADFA Sep 5, 2026
7f34c6e
feat(metrics): colour the throttle bands, label power in watts, stagg…
davidschachterADFA Sep 6, 2026
59d6851
fix(metrics): put the sampling-rate tap on the edge the x axis is dra…
davidschachterADFA Sep 6, 2026
b53677d
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
c12bc1e
fix(metrics): address four review findings on the carousel (ADFA-5486)
davidschachterADFA Sep 6, 2026
7a92309
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
5028834
docs(metrics): correct the sign contract on the battery current (ADFA…
davidschachterADFA Sep 6, 2026
34353ea
Merge remote-tracking branch 'origin/feature/ADFA-5499-power-chart' i…
davidschachterADFA Sep 6, 2026
8e68679
fix(metrics): put the sampling-rate tap on the edge the x axis is dra…
davidschachterADFA Sep 6, 2026
245d95d
fix(metrics): make the network sampling loop stoppable and crash-proo…
davidschachterADFA Sep 6, 2026
afdd6ae
fix(metrics): actually apply the sampler fix, and stop a failed test …
davidschachterADFA Sep 6, 2026
1b107df
Merge branch 'feature/ADFA-5489-network-traffic-page' into feature/AD…
davidschachterADFA Sep 6, 2026
9116990
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
717f509
fix(metrics): close out the remaining review findings on the carousel…
davidschachterADFA Sep 6, 2026
a524280
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
8f794a3
fix(metrics): hide the whole strip when the carousel undocks (ADFA-5486)
davidschachterADFA Sep 6, 2026
4b03b6e
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
0984cb5
feat(metrics): add long-press help to the metrics carousel (ADFA-5510)
davidschachterADFA Sep 6, 2026
aa7c719
fix(metrics): scale the network axis to the visible window (ADFA-5486)
davidschachterADFA Sep 6, 2026
521564b
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
fae5848
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
ec28537
feat(metrics): annotate build start, finish and failure on the charts…
davidschachterADFA Sep 6, 2026
aeac2bb
fix(metrics): guard the snapshot share, and clamp the rate where the …
davidschachterADFA Sep 6, 2026
eb98d74
docs(metrics): re-attach the rebuild KDoc the help tag displaced (ADF…
davidschachterADFA Sep 6, 2026
c0ddf1f
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
d442b36
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
e1a7bf5
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
c0a1c16
fix(metrics): stop annotating syncs and cancels as builds (ADFA-5509)
davidschachterADFA Sep 6, 2026
eb4335b
fix(metrics): make the carousel work in the floating window (ADFA-5486)
davidschachterADFA Sep 6, 2026
8fad3ad
fix(metrics): scale the memory axis to the visible window too (ADFA-5…
davidschachterADFA Sep 6, 2026
cfd67a6
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
9f15dd8
fix(metrics): range the power axes, and give the watcher its siblings…
davidschachterADFA Sep 6, 2026
be9873b
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
203729b
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
fb5bc7b
fix(metrics): re-baseline on resume, and stop sampling a device that …
davidschachterADFA Sep 6, 2026
837b8a1
Merge branch 'feature/ADFA-5489-network-traffic-page' into feature/AD…
davidschachterADFA Sep 6, 2026
c34b648
fix(metrics): report network traffic as the rate the legend claims (A…
davidschachterADFA Sep 6, 2026
0464fbe
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
379b91c
fix(metrics): keep the undocked message's help, and stop the target l…
davidschachterADFA Sep 6, 2026
fa15b29
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
5d00a79
fix(metrics): correctness findings from review on the carousel (ADFA-…
davidschachterADFA Sep 6, 2026
092b633
refactor: delete SwipeRevealLayout's two dead horizontal drag helpers
davidschachterADFA Sep 6, 2026
4c65554
fix(metrics): stop sampling for an abandoned activity, and tidy the r…
davidschachterADFA Sep 6, 2026
5676677
fix(metrics): snapshot the memory history, window the annotations, cl…
davidschachterADFA Sep 6, 2026
14aae3f
ADFA-5499: address review findings on the power page
davidschachterADFA Sep 6, 2026
93bee8c
ADFA-5510: address review findings on the carousel's help
davidschachterADFA Sep 6, 2026
7b50282
ADFA-5499: keep the battery readout off the topmost axis label
davidschachterADFA Sep 6, 2026
d05b32c
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
5b4016c
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
531c072
ADFA-5509: address review findings on the build annotations
davidschachterADFA Sep 6, 2026
963e37b
ADFA-5509: dim the end arrows rather than disabling them
davidschachterADFA Sep 6, 2026
90ee074
ADFA-5510: let the end arrows answer a long press, without losing the…
davidschachterADFA Sep 6, 2026
1573eef
ADFA-5509: move the end-arrow change to ADFA-5510, where it belongs
davidschachterADFA Sep 6, 2026
26b6126
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
a569642
Merge remote-tracking branch 'origin/feature/ADFA-5486-chart-improvem…
davidschachterADFA Sep 6, 2026
f31ebd8
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
62f0b6c
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
6596564
ADFA-5499: make the carousel adapter actually page-agnostic
davidschachterADFA Sep 6, 2026
3dc11db
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
fcff821
ADFA-5510: give the new adapter test's renderer a help tag
davidschachterADFA Sep 6, 2026
f22fc16
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
4341746
ADFA-5499: set axis bounds before the notify, and publish watcher state
davidschachterADFA Sep 6, 2026
43d922b
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
1440c4a
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
55c553d
ADFA-5509: forward the cancel request, so BUILD_CANCELLED can happen
davidschachterADFA Sep 6, 2026
7cdbfa9
ADFA-5486: fix the undocked carousel's invisible arrows and lost page
davidschachterADFA Sep 6, 2026
f9119a4
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
21dbe68
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
a434d78
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
f9b39e2
ADFA-5510: give the window's close control a tag of its own
davidschachterADFA Sep 6, 2026
490bc97
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
bbf3ab1
ADFA-5486: one snapshot at a time, and track tap pointers by id
davidschachterADFA Sep 6, 2026
935fae8
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 6, 2026
914ebbc
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 6, 2026
4af1c8f
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 6, 2026
26e298d
ADFA-5486: fix the axis the memory lines use, and make panning stick
davidschachterADFA Sep 7, 2026
6525024
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 7, 2026
ae6736a
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 7, 2026
64abd62
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 7, 2026
498f3d4
ADFA-5510: sweep the last setOnLongClickListener(null) site
davidschachterADFA Sep 7, 2026
39f494c
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 7, 2026
d5c67c5
ADFA-5509: clear the build flags before the activity check
davidschachterADFA Sep 7, 2026
2d4453c
ADFA-5486: put the share flags on the chooser, and widen the marker span
davidschachterADFA Sep 7, 2026
fb99a91
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 7, 2026
68f052a
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 7, 2026
c2b5c00
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 7, 2026
1f9c498
ADFA-5527: follow the font scale in the charts, up to a ceiling
davidschachterADFA Sep 7, 2026
38e6878
ADFA-5527: measure the plot the eight rows have to fit in
davidschachterADFA Sep 7, 2026
bbf5c35
ADFA-5531: record when each sample was taken
davidschachterADFA Sep 7, 2026
7393056
ADFA-5531: define the canonical metrics file, and name every export t…
davidschachterADFA Sep 7, 2026
3ba8bbc
ADFA-5531: add the export button to the carousel
davidschachterADFA Sep 7, 2026
00dbafa
ADFA-5515: apply the chart's newest window against the transform it w…
davidschachterADFA Sep 7, 2026
3e3869b
ADFA-5531: read a row's time and its values as one moment
davidschachterADFA Sep 7, 2026
53ef2d2
ADFA-5515: clear the pan flag when a rebind replaces the chart
davidschachterADFA Sep 7, 2026
68d7529
ADFA-5487: drop the emptied init block, and put the KDoc back on its …
davidschachterADFA Sep 7, 2026
53bdaa8
ADFA-5531: spell the header out, instead of deriving it from the code
davidschachterADFA Sep 7, 2026
f16e460
ADFA-5534: assemble the metrics snapshot without a carousel
davidschachterADFA Sep 7, 2026
51a2b24
ADFA-5526: copy a history into a destination, and retain fewer samples
davidschachterADFA Sep 7, 2026
766d0ff
ADFA-5534: a gzipped copy of the metrics file, and a way to ask if it…
davidschachterADFA Sep 7, 2026
e4c43d8
ADFA-5526: pre-allocate the snapshot destinations, and make them reac…
davidschachterADFA Sep 7, 2026
77db440
ADFA-5534: attach the metrics file to feedback
davidschachterADFA Sep 7, 2026
98141c7
ADFA-5526: attach the metrics to every report
davidschachterADFA Sep 7, 2026
50aacfc
ADFA-5534: fix pruning here, where its test lives
davidschachterADFA Sep 7, 2026
020459c
ADFA-5526: prove the attachment reaches the envelope
davidschachterADFA Sep 7, 2026
6054780
ADFA-5534: measure compression against noise, not a ramp
davidschachterADFA Sep 7, 2026
f89e523
ADFA-5526: close the blocks the rebase resolution left open
davidschachterADFA Sep 7, 2026
7a17f2c
ADFA-5486: ask where the carousel is before binding one, and stop thr…
davidschachterADFA Sep 7, 2026
5d89cea
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 7, 2026
6ec7f88
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 7, 2026
a8225f2
ADFA-5510: keep the legend out of the axis tap band
davidschachterADFA Sep 7, 2026
7509593
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 7, 2026
712b0b1
Merge branch 'feature/ADFA-5509-build-annotations' into feature/ADFA-…
davidschachterADFA Sep 7, 2026
3d7ec4a
Merge branch 'feature/ADFA-5515-carousel-resume-viewport' into featur…
davidschachterADFA Sep 7, 2026
83648ec
Merge branch 'feature/ADFA-5527-chart-font-scale' into feature/ADFA-5…
davidschachterADFA Sep 7, 2026
31e10df
ADFA-5531: stop the file reporting sentinels and a lost watch time
davidschachterADFA Sep 7, 2026
b8fab20
Merge branch 'feature/ADFA-5531-metrics-csv-export' into feature/ADFA…
davidschachterADFA Sep 7, 2026
d7a6756
ADFA-5534: put the whole attachment step inside the guard it claims
davidschachterADFA Sep 7, 2026
98d0b2d
Merge branch 'feature/ADFA-5534-metrics-in-feedback' into feature/ADF…
davidschachterADFA Sep 7, 2026
489cf63
ADFA-5526: stop paying for a fresh file on every report
davidschachterADFA Sep 7, 2026
8786d3f
ADFA-5553: a dot for the legend, set where it actually holds
davidschachterADFA Sep 7, 2026
1b5deed
ADFA-5553: fix the review findings, including a vacuous assertion of …
davidschachterADFA Sep 7, 2026
c82cb5b
ADFA-5553: scale the legend's third gap, and stop claiming a shared c…
davidschachterADFA Sep 7, 2026
0d475fc
ADFA-5554: hold, rather than brush, to get help
davidschachterADFA Sep 7, 2026
49a6c7d
ADFA-5542: say which build a cancel belongs to
davidschachterADFA Sep 7, 2026
ac5ff67
ADFA-5553: fix the review findings - units, per-tick cost, untested gaps
davidschachterADFA Sep 7, 2026
3d21bd6
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 7, 2026
ac03b12
ADFA-5554: fix the review findings across the chart and the hold
davidschachterADFA Sep 8, 2026
e6123be
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
c6d6393
ADFA-5542: route the server's own verdict instead of guessing it
davidschachterADFA Sep 8, 2026
a3c90ad
ADFA-5499: hide the battery readout when the carousel undocks
davidschachterADFA Sep 8, 2026
288cf95
Merge branch 'feature/ADFA-5515-carousel-resume-viewport' into featur…
davidschachterADFA Sep 8, 2026
7f5d00e
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 8, 2026
db67fff
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 8, 2026
c6c8eb1
Merge branch 'feature/ADFA-5509-build-annotations' into feature/ADFA-…
davidschachterADFA Sep 8, 2026
e88a38f
Merge branch 'feature/ADFA-5527-chart-font-scale' into feature/ADFA-5…
davidschachterADFA Sep 8, 2026
757dec1
ADFA-5531: hide the export button when the carousel undocks
davidschachterADFA Sep 8, 2026
ebd09ae
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 8, 2026
8e3d0e7
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
f56c085
Merge branch 'feature/ADFA-5526-metrics-in-crash-reports' into featur…
davidschachterADFA Sep 8, 2026
7dc38c8
Merge branch 'feature/ADFA-5531-metrics-csv-export' into feature/ADFA…
davidschachterADFA Sep 8, 2026
ef0d47a
Merge branch 'feature/ADFA-5534-metrics-in-feedback' into feature/ADF…
davidschachterADFA Sep 8, 2026
be353d9
ADFA-5554: fix the second review round, and the heap that hid it
davidschachterADFA Sep 8, 2026
042c1d3
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
29e0789
ADFA-5542: report a cancelled build as cancelled everywhere, not just…
davidschachterADFA Sep 8, 2026
3c61b46
ADFA-5574: read each watched process the cheapest correct way
davidschachterADFA Sep 8, 2026
6246453
ADFA-5499: fix the re-review findings on the power page
davidschachterADFA Sep 8, 2026
483271c
Merge branch 'feature/ADFA-5499-power-chart' into feature/ADFA-5510-c…
davidschachterADFA Sep 8, 2026
9be288c
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 8, 2026
c3b5a7c
Merge branch 'feature/ADFA-5509-build-annotations' into feature/ADFA-…
davidschachterADFA Sep 8, 2026
e75d9ea
Merge branch 'feature/ADFA-5527-chart-font-scale' into feature/ADFA-5…
davidschachterADFA Sep 8, 2026
4c228bb
Merge branch 'feature/ADFA-5515-carousel-resume-viewport' into featur…
davidschachterADFA Sep 8, 2026
fdcb241
ADFA-5531: fix the review's export findings
davidschachterADFA Sep 8, 2026
572cffc
ADFA-5553: stop reserving the legend's offset twice
davidschachterADFA Sep 8, 2026
b7d9b69
ADFA-5554: a cancelled gesture is not a lift, and the heap raise was …
davidschachterADFA Sep 8, 2026
a18fdbd
ADFA-5542: finish the sweep, and stop leaking the cancellation token
davidschachterADFA Sep 8, 2026
68d8666
Merge branch 'feature/ADFA-5531-metrics-csv-export' into feature/ADFA…
davidschachterADFA Sep 8, 2026
999a8d5
Merge branch 'feature/ADFA-5534-metrics-in-feedback' into feature/ADF…
davidschachterADFA Sep 8, 2026
2ba887f
Merge branch 'feature/ADFA-5526-metrics-in-crash-reports' into featur…
davidschachterADFA Sep 8, 2026
f5c01f5
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 8, 2026
e9c8144
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
f1e8420
Merge branch 'feature/ADFA-5542-cancel-by-build-id' into feature/ADFA…
davidschachterADFA Sep 8, 2026
2f4cc8e
ADFA-5553: reindent the fixture the merge resolution left
davidschachterADFA Sep 8, 2026
d6d2772
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 8, 2026
349db0e
ADFA-5554: reindent the fixtures the merge resolution left
davidschachterADFA Sep 8, 2026
800853b
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
a8e2e34
Merge branch 'feature/ADFA-5542-cancel-by-build-id' into feature/ADFA…
davidschachterADFA Sep 8, 2026
c697bd3
ADFA-5531: give the three process names one home
davidschachterADFA Sep 8, 2026
01ffa58
ADFA-5554: one harness for the two chart-gesture test classes
davidschachterADFA Sep 8, 2026
0b68ae3
ADFA-5531: test the export file, and fix the pruning it exposed
davidschachterADFA Sep 8, 2026
0a17b20
Merge branch 'feature/ADFA-5542-cancel-by-build-id' into feature/ADFA…
davidschachterADFA Sep 8, 2026
cadc979
Merge branch 'feature/ADFA-5531-metrics-csv-export' into feature/ADFA…
davidschachterADFA Sep 8, 2026
7875bd4
Merge branch 'feature/ADFA-5534-metrics-in-feedback' into feature/ADF…
davidschachterADFA Sep 8, 2026
1363b2a
Merge branch 'feature/ADFA-5526-metrics-in-crash-reports' into featur…
davidschachterADFA Sep 8, 2026
6f17e35
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 8, 2026
27aa553
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 8, 2026
63c994b
ADFA-5574: chart guards at the size the strip actually gives the plot
davidschachterADFA Sep 8, 2026
4824a99
Merge branch 'stage' into feature/ADFA-5487-metrics-carousel
davidschachterADFA Sep 8, 2026
1ce7340
Merge branch 'feature/ADFA-5487-metrics-carousel' into feature/ADFA-5…
davidschachterADFA Sep 8, 2026
ddf91b0
Merge branch 'feature/ADFA-5489-network-traffic-page' into feature/AD…
davidschachterADFA Sep 8, 2026
ba6c3d0
Merge branch 'feature/ADFA-5486-chart-improvements' into feature/ADFA…
davidschachterADFA Sep 8, 2026
37a2a80
ADFA-5574: take the carousel's last English words out of the code
davidschachterADFA Sep 9, 2026
a82b666
Merge remote-tracking branch 'origin/feature/ADFA-5499-power-chart' i…
davidschachterADFA Sep 9, 2026
d8e9709
Merge branch 'feature/ADFA-5510-carousel-help' into feature/ADFA-5509…
davidschachterADFA Sep 9, 2026
833d00b
Merge branch 'feature/ADFA-5509-build-annotations' into feature/ADFA-…
davidschachterADFA Sep 9, 2026
1936bd0
Merge branch 'feature/ADFA-5527-chart-font-scale' into feature/ADFA-5…
davidschachterADFA Sep 9, 2026
0cc1ee4
Merge branch 'feature/ADFA-5515-carousel-resume-viewport' into featur…
davidschachterADFA Sep 9, 2026
d00d3d9
Merge branch 'feature/ADFA-5531-metrics-csv-export' into feature/ADFA…
davidschachterADFA Sep 9, 2026
5a96d56
Merge branch 'feature/ADFA-5534-metrics-in-feedback' into feature/ADF…
davidschachterADFA Sep 9, 2026
0932ede
Merge branch 'feature/ADFA-5526-metrics-in-crash-reports' into featur…
davidschachterADFA Sep 9, 2026
65ad142
Merge branch 'feature/ADFA-5553-legend-dots' into feature/ADFA-5554-l…
davidschachterADFA Sep 9, 2026
e37858e
Merge branch 'feature/ADFA-5554-longer-tooltip-hold' into feature/ADF…
davidschachterADFA Sep 9, 2026
aaa17d3
Merge branch 'feature/ADFA-5542-cancel-by-build-id' into feature/ADFA…
davidschachterADFA Sep 9, 2026
f607f03
ADFA-5542: follow stage's move of finish() onto the reporter
davidschachterADFA Sep 9, 2026
fe1a7e9
Merge branch 'feature/ADFA-5542-cancel-by-build-id' into feature/ADFA…
davidschachterADFA Sep 9, 2026
8c5beca
ADFA-5530: consolidate the carousel stack onto stage
davidschachterADFA Sep 9, 2026
ce905e0
ADFA-5530: fix two defects review found in the carousel
davidschachterADFA Sep 9, 2026
ab28003
ADFA-5530: guard the undocked message at 2x text
davidschachterADFA Sep 9, 2026
edc8677
ADFA-5530: stop handing out live buffers, and fix the thermal sentinel
davidschachterADFA Sep 9, 2026
08f45ed
ADFA-5530: close the registration race, and stop leaking the battery …
davidschachterADFA Sep 9, 2026
25b09a7
ADFA-5530: recycle the snapshot bitmap even when the export is cancelled
davidschachterADFA Sep 9, 2026
0af5cda
Merge remote-tracking branch 'origin/stage' into feature/ADFA-5530-ca…
davidschachterADFA Sep 9, 2026
a29a051
ADFA-5530: take the floating carousel down with the editor
davidschachterADFA Sep 9, 2026
1c8f78b
ADFA-5530: make the scratch guard real, and stop two samplers racing
davidschachterADFA Sep 9, 2026
a07df0a
ADFA-5530: clear the next arrow of the resize grip, and drop the lege…
davidschachterADFA Sep 9, 2026
7be4cd1
ADFA-5530: correct a milliamp power reading instead of discarding it
davidschachterADFA Sep 9, 2026
7ada796
ADFA-5530: say "single-tap" in the undocked carousel message
davidschachterADFA Sep 9, 2026
cc08993
ADFA-5530: don't sample until the carousel is first shown
davidschachterADFA Sep 10, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion REVIEW.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Help in CoGo is reached by **long-press**, anywhere: a progressive three-tier ex
- **Wire up help on new interactive elements.** Anything tappable — buttons, icon controls, menu items, list rows, toolbar actions — gets long-press help. A new actionable view with no tooltip is as incomplete as a missing `contentDescription`.
- **Cover new screens and panels too.** Even where pixels aren't interactive, a new screen/panel/dialog needs a top-level help entry so help is always reachable.
- **The affordance is the requirement, not finished copy.** Tooltip content may still be in authoring — fine — but the long-press must be wired and routed into the tier system. Don't ship UI that can never surface help.
- **Reuse the system.** Wire help through `idetooltips` — today the `View.displayTooltipOnLongPress(context, anchorView, category, tag)` extension (`setOnLongClickListener` → `TooltipManager.showTooltip`) — not a one-off popup.
- **Reuse the system.** Wire help through `idetooltips` — today the `View.displayTooltipOnLongPress(context, tooltipTag, tooltipCategory, holdMillis)` extension (a long-click listener for the framework's own gesture, plus a touch listener that times the longer hold ADFA-5554 asks for, both reaching `TooltipManager.showTooltip`) — not a one-off popup.
- **Compose has no native entry point yet** (tracked by **ADFA-4381**). The helper is View-based (needs an `anchorView`), so until `idetooltips` grows a Compose API, a composable wires help via `AndroidView` interop. Flag it in review rather than skipping help, and build the reusable `Modifier`/wrapper once instead of copy-pasting interop.

## 10. Architecture alignment
Expand Down
3 changes: 3 additions & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,9 @@ dependencies {
implementation(libs.androidx.work)
implementation(libs.androidx.work.ktx)
implementation(libs.google.material)
// Metrics carousel (ADFA-5487). Already on the classpath transitively; declared so the
// compile-time use in MetricsCarouselAdapter does not depend on another library's graph.
implementation(libs.androidx.viewpager2.v110beta02)
implementation(libs.google.flexbox)
implementation(libs.libsu.core)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import com.itsaky.androidide.lookup.Lookup
import com.itsaky.androidide.projects.builder.BuildService
import com.itsaky.androidide.resources.R
import com.itsaky.androidide.utils.flashError
import com.itsaky.androidide.utils.requestBuildCancellation
import org.slf4j.Logger
import org.slf4j.LoggerFactory

Expand Down Expand Up @@ -77,34 +78,13 @@ abstract class AbstractCancellableRunAction(
protected abstract fun doExec(data: ActionData): Any

protected fun cancelBuild(): Boolean {
log.info("Sending build cancellation request...")
val builder = Lookup.getDefault().lookup(BuildService.KEY_BUILD_SERVICE)
if (builder?.isToolingServerStarted() != true) {
flashError(com.itsaky.androidide.projects.R.string.msg_tooling_server_unavailable)
return false
}

builder.cancelCurrentBuild().whenComplete {
result,
error,
->
if (error != null) {
log.error("Failed to send build cancellation request", error)
return@whenComplete
}

if (!result.wasEnqueued) {
log.warn(
"Unable to enqueue cancellation request reason={} reason.message={}",
result.failureReason,
result.failureReason!!.message,
)
return@whenComplete
}

log.info("Build cancellation request was successfully enqueued...")
}

requestBuildCancellation(builder)
return true
}

Expand Down
Loading
Loading