Skip to content

fix: handle Actors without a description in ApifyActorsTool - #50

Merged
daveomri merged 3 commits into
mainfrom
fix/fix-the-apifyactorstool-regression
Nov 5, 2026
Merged

daveomri merged 3 commits into
mainfrom
fix/fix-the-apifyactorstool-regression

Conversation

@daveomri

@daveomri daveomri commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

ApifyActorsTool crashed with a TypeError on Actors without a description in actor.json (e.g. apify/web-scraper, apify/google-trends-scraper), because since apify-client 3.4.0 the build dump returns it as None instead of leaving it out. Both actorDefinition reads now treat None like a missing key, and uv.lock moves to apify-client 3.4.0 so the tests run against what users install.

Part of apify/dx-heroes-team#31.

@daveomri daveomri self-assigned this Nov 3, 2026
@daveomri
daveomri requested a review from vdusek November 3, 2026 13:31
@daveomri
daveomri marked this pull request as ready for review November 3, 2026 13:31
@daveomri
daveomri requested a review from protoss70 November 3, 2026 13:31

@vdusek vdusek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits like comments/docstrings clarity, and test case ids; otherwise LGTM 🚀.

Comment thread langchain_apify/tools/actors.py Resolved
Comment thread tests/unit_tests/test_actor_build.py Resolved
Comment thread tests/unit_tests/test_actor_build.py Resolved
Comment thread tests/unit_tests/test_actor_build.py Resolved
Comment thread tests/unit_tests/test_actor_build.py Resolved
@daveomri
daveomri merged commit 5554ec9 into main Nov 5, 2026
10 checks passed
@daveomri
daveomri deleted the fix/fix-the-apifyactorstool-regression branch November 5, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants