Repository navigation
fix(utils): extract URLs with internationalized top-level domains - #4380
Open
SwastikTripathi wants to merge 1 commit into
Open
SwastikTripathi wants to merge 1 commit into
SwastikTripathi wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractUrls()anddownloadListOfUrls()miss URLs on internationalized top-level domains, and cut punycode ones short:URL_NO_COMMAS_REGEXandURL_WITH_COMMAS_REGEXalready accept Unicode letters in the host labels (\p{L}), but the TLD was[a-z]{2,63}. So.рф,.中国or.みんなnever matched, and for a punycode TLD the regex stopped atxnand returned a URL with the wrong host.The TLD is now
xn--[a-z0-9-]{1,59}or[\p{L}\p{M}]{2,63}, with the punycode branch first soxn--p1aiis taken whole. I also added\p{M}next to\p{L}after the first character of the host and in the path, because scripts like Devanagari write vowel signs as combining marks:https://उदाहरण.भारत/pagestopped at the first mark before. The first character of the host is unchanged.The new test (5 URLs, both regexes) fails before the change.
test/utilsand the enqueue-links tests pass (220), and oxlint/oxfmt are clean.