Repository navigation
fix(utils): keep published and export Google Sheets URLs in downloadListOfUrls - #4353
Closed
SwastikTripathi wants to merge 1 commit into
Closed
SwastikTripathi wants to merge 1 commit into
SwastikTripathi wants to merge 1 commit into
Conversation
…istOfUrls Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
the
t-tooling
This was referenced Nov 10, 2026
barjin
added a commit
that referenced
this pull request
Nov 10, 2026
…rls` (#4377) The rewrite moved to `Actor.getInput()` in the Apify SDK (apify/apify-sdk-js#859). Closes #4353
Member
|
Closed by #4377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadListOfUrlsrewrites anyhttps://docs.google.com/spreadsheets/d/<id>...URL to<id>/gviz/tq?tqx=out:csv, so a sharing link downloads as CSV. The regex also matched links that were already downloadable:https://docs.google.com/spreadsheets/d/e/2PACX-.../pub?output=csv, tookeas the id and becamehttps://docs.google.com/spreadsheets/d/e/gviz/tq?tqx=out:csv, which Google answers with a 404..../gviz/tq?tqx=out:csv&sheet=Secondand.../export?format=csv&gid=123both became the plain export of the first sheet.The rewrite now skips
/d/e/links and links whose path continues with/gvizor/export. Sharing links (/edit?usp=sharing, or the bare/d/<id>) are rewritten as before.Three tests in
extract-urls.test.tscheck the URL passed to the HTTP client; the published and export cases fail without the change. I also fetched the rewritten/d/e/gviz/tq?tqx=out:csvURL to confirm the 404.Written with Claude Code (AI). I ran the tests and the request above.