Repository navigation
fix: add support for Scrapy 2.20 - #1242
Merged
Merged
Conversation
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 54 54
Lines 3801 3803 +2
=======================================
+ Hits 3567 3569 +2
Misses 234 234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
November 9, 2026 07:13
apify-service-account
added
the
tested
![apify-approval-mirror[bot]](https://avatars.githubusercontent.com/u/24586296?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the lock file to Scrapy 2.20.0 and w3lib 2.6.0, which #1241 held back because they broke the Scrapy unit tests.
Scrapy 2.20 deprecates
Headers.to_unicode_dict(), whichto_apify_requestcalled for every enqueued request. The headers are now decoded straight fromHeaders.items(), which works the same on every supported Scrapy version (2.14 and up) and raises no warning. Decoding stays strict, so non-UTF-8 headers still fall back to the serialized request.to_tuple_list()would turn them into U+FFFD characters instead.w3lib 2.6 adds a trailing slash to URLs with an empty path (
https://example.combecomeshttps://example.com/). Unique keys are unaffected because Crawlee strips that slash when computing them, so only tests asserting exact root URLs failed. They now use the trailing-slash form, which both w3lib versions leave unchanged.Unit tests pass on Scrapy 2.20.0, 2.19.0, and 2.14.0.
✍️ Drafted by Claude Code