Repository navigation
Conversation
Do not merge. This PR exists only to verify that the E2E CI from #1235 installs the SDK from the branch source: every E2E Actor that pushes data must fail with the canary RuntimeError. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_017ocuAKrYEZDsqeRhDK6VAp
github-actions
Bot
added
the
t-tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/scrapy-e2e-w3lib-trailing-slash #1238 +/- ##
====================================================================
Coverage 93.81% 93.81%
====================================================================
Files 54 54
Lines 3800 3802 +2
====================================================================
+ Hits 3565 3567 +2
Misses 235 235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. This PR only checks that the E2E CI from #1235 installs the SDK from the branch source rather than from PyPI.
It is based on #1235 and adds one deliberate break on top of it:
Actor.push_data()raises aRuntimeErrorwhenever the Actor runs on the platform (Actor.is_at_home()). Local runs and unit tests are unaffected, so the only expected red checks are the E2E jobs.Expected outcome: every E2E test whose Actor pushes data fails with
E2E CI canary: the SDK was installed from the branch source, not from PyPI. If the E2E jobs pass instead, the test Actors are not running the SDK from the branch.Generated by Claude Code