Skip to content

chore: Look for input in default key-value store instead of the storage root - #826

Merged
janbuchar merged 2 commits into
masterfrom
fix-input-loading
Oct 22, 2026
Merged

janbuchar merged 2 commits into
masterfrom
fix-input-loading

Conversation

@janbuchar
janbuchar requested a review from szaganek as a code owner October 21, 2026 09:36
@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 21, 2026
@janbuchar janbuchar self-assigned this Oct 21, 2026
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 21, 2026

@vladfrangu vladfrangu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a NIT that I am sure AI can tackle but shouldn't block the PR

Comment thread src/actor.ts Resolved

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @janbuchar !

Btw what was the idea behind reading the INPUT.json from the working directory? tbh this is the first time I'm seeing this pattern 👀

@janbuchar

Copy link
Copy Markdown
Contributor Author

Btw what was the idea behind reading the INPUT.json from the working directory? tbh this is the first time I'm seeing this pattern 👀

In 3.x, crawlee had this implemented on KeyValueStore.getInput. The method was (presumably) used very rarely, all documentation pointed to Actor.getInput, which didn't do this.

@janbuchar
janbuchar enabled auto-merge (squash) October 22, 2026 12:21
@janbuchar
janbuchar disabled auto-merge October 22, 2026 12:21
@janbuchar
janbuchar enabled auto-merge (squash) October 22, 2026 12:25
@janbuchar
janbuchar merged commit 6408452 into master Oct 22, 2026
15 of 16 checks passed
@janbuchar
janbuchar deleted the fix-input-loading branch October 22, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants