Repository navigation
feat(charging): track deduplicated charges under an idempotency key - #777
Merged
Merged
Conversation
A repeated charge under a key seen in the last three minutes is skipped locally as well as at the API, so the charging state no longer drifts from the platform. Mirrors apify/apify-sdk-python#1123. Closes #733
github-actions
Bot
added
the
t-tooling
apify-service-account
added
the
tested
|
See more at https://github.com/apify/apify-sdk-js/actions/runs/38525583727#summary-115725043212 |
barjin
approved these changes
Oct 14, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @vladfrangu , it seems to match the Python implementation in the important parts 👍 lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #733. Mirrors apify/apify-sdk-python#1123.
A repeated
Actor.charge()under anidempotencyKeyseen in the last three minutes is now skipped locally as well as at the API, so the charging state andmaxTotalChargeUsdaccounting no longer drift from the platform.chargedCount; a repeat naming a different event warns and reports zero.Keys are kept in a small timestamped map pruned lazily, no new dependency.
[🤖] Claude Code using Fable 5.1