Skip to content

test: use the run token for metamorph in integration tests - #1220

Open
mvolfik wants to merge 1 commit into
masterfrom
fix/metamorph-test
Open

mvolfik wants to merge 1 commit into
masterfrom
fix/metamorph-test

Conversation

@mvolfik

@mvolfik mvolfik commented Nov 10, 2026

Copy link
Copy Markdown
Member

fix for breaking change from apify/apify-core#32513

@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 10, 2026
@mvolfik mvolfik added t-core-services Issues with this label are in the ownership of the core services team. adhoc Ad-hoc unplanned task added during the sprint. labels Nov 10, 2026
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 10, 2026
@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.76%. Comparing base (eb8ded4) to head (b2df23f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1220   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          63       63           
  Lines        6676     6676           
=======================================
  Hits         6393     6393           
  Misses        283      283           
Flag Coverage Δ
integration 91.05% <ø> (+0.38%) ⬆️
unit 91.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Factory review — ℹ️ not auto-approved

This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.

check result
Static gates ❌ 15/16 — no-risky-content
Review findings ✅ none
Reviewer escalation ✅ none
Juror 1 — claude-sonnet-5-5, adversarial ⏭️ skipped — a gate failed
Why it was not auto-approved

Failed gates:

  • no-risky-content: tests/_utils.py: environment variable access (env-access); tests/integration/test_run.py: environment variable access (env-access)

The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.

Reviewed b2df23f71 · workflow run

@mvolfik
mvolfik requested a review from vdusek November 10, 2026 14:48
@vdusek vdusek changed the title fix: use run token in metamorph test, as metamorphing from outside is not allowed anymore test: use the run token for metamorph in integration tests Nov 11, 2026

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvolfik. Did you open the PR manually or via agent?

I renamed it to the "test" type, since the change touches only tests, not the source code (we don't want this in changelog).

I'm asking because our CLAUDE.md links to the commit conventions, so I'm curios whether your agent ignores it for some reason or not, because you opened it manually (if you wrote the title yourself, then it's ok).

@mvolfik

mvolfik commented Nov 11, 2026

Copy link
Copy Markdown
Member Author

nope, it was done manually :) fair point, in apify-core, the commit conventions are a bit of a wild west (mostly because we don't have to care about semver that much), thanks for fixing it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-core-services Issues with this label are in the ownership of the core services team. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants