Skip to content

docs: document gzip default and brotli extra for request compression - #1209

Merged
vdusek merged 3 commits into
apify:masterfrom
dheerajitbhu:docs/compression-default-docstring
Nov 9, 2026
Merged

vdusek merged 3 commits into
apify:masterfrom
dheerajitbhu:docs/compression-default-docstring

Conversation

@dheerajitbhu

@dheerajitbhu dheerajitbhu commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #1179.

The compression docstring on ApifyClient / ApifyClientAsync did not say what the default is or that 'brotli' needs an optional extra. That made the difference from the JS client (which defaults to brotli via node:zlib) hard to discover.

This updates the sync docstring (copied to async via poe fix-docstrings) to state:

  • default is 'gzip'
  • 'brotli' needs pip install "apify-client[brotli]"
  • gzip stays the default because brotli is a native package and would add a required compiled dependency

No behavior change.

Test plan

  • uv run poe fix-docstrings synced async from sync
  • uv run poe lint (ruff format + check) passes
  • Docs render the updated Args entry for ApifyClient / ApifyClientAsync

AI assistance: drafted with Cursor; docstring wording reviewed against CONTRIBUTING (describes current behavior only) and the recommendation in #1179.

@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 6, 2026

@vdusek vdusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek
vdusek merged commit 41c6f39 into apify:master Nov 9, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document why the default request compression differs from the JS client

2 participants