Skip to content

test: stabilize test_actor_last_run against concurrent run deletions #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Nov 2, 2026
Merged

test: stabilize test_actor_last_run against concurrent run deletions #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/integration/test_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from datetime import UTC, datetime, timedelta
from typing import TYPE_CHECKING

from .._utils import get_random_resource_name, maybe_await
from .._utils import get_random_resource_name, maybe_await, poll_until_condition
from apify_client._models import (
ActorChargeEvent,
ActorListItem,
Expand Down Expand Up @@ -171,10 +171,14 @@ async def test_actor_last_run(client: ApifyClient | ApifyClientAsync) -> None:
last_run_client = actor_client.last_run()
assert last_run_client is not None

# Use the returned client to get the run
last_run = await maybe_await(last_run_client.get())
# Parallel tests share this account and keep finishing and deleting hello-world runs, so "last" may
# resolve to a run deleted before the API serves it (404 -> None). Poll past that window.
last_run = await poll_until_condition(
lambda: maybe_await(last_run_client.get()),
lambda r: isinstance(r, Run) and r.started_at >= run.started_at,
)
assert isinstance(last_run, Run)
assert last_run.id is not None
assert last_run.started_at >= run.started_at

finally:
await maybe_await(client.run(run.id).delete())
Expand Down
Loading