Repository navigation
fix: include request method and path in ApifyApiError messages - #1185
Merged
Merged
Conversation
Signed-off-by: Emre K <[email protected]>
github-actions
Bot
added
the
t-tooling
vdusek
changed the title
ApifyApiError messages
vdusek
self-requested a review
November 2, 2026 10:56
vdusek
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApifyApiError, without exposing URL query parameters (includingtoken). Custom HTTP clients constructing the error without a URL keep the existing exception text.Fixes #1177
Verification
uv run --extra httpx2 --extra brotli pytest tests/unit/test_client_errors.py -k 'identifies_request_without_exposing_query_token or empty_body_names_http_status' -q -o addopts='' --tb=short→ 6 expected failures (missingpath, empty-body fallback missing HTTP 502).uv run --extra httpx2 --extra brotli pytest tests/unit/test_client_errors.py -q -o addopts='' --tb=short→ 94 passed.uv run --extra httpx2 --extra brotli pytest tests/unit -q -n 4 -o addopts='' --tb=short→ 2418 passed, 1 skipped.uv run --extra httpx2 --extra brotli ruff check src/apify_client/errors.py src/apify_client/http_clients/_base.py tests/unit/test_client_errors.py→ passed.uv run --extra httpx2 --extra brotli ruff format --check src/apify_client/errors.py src/apify_client/http_clients/_base.py tests/unit/test_client_errors.py→ passed.uv run --extra httpx2 --extra brotli poe check-docstringsanduv run --extra httpx2 --extra brotli ty check src/apify_client/errors.py src/apify_client/http_clients/_base.py→ passed.git diff --check→ passed. No live Apify API calls.AI assistance: implementation and tests were developed with an AI agent and verified locally.