Skip to content

batch_add_requests() raises on a failed batch and loses the partial result #1092

Open

Description

@vdusek

When one batch call in RequestQueueClient.batch_add_requests() fails, the exception propagates and the requests already added by earlier batches are lost from the result. The caller can't tell which requests made it into the queue (_resource_clients/request_queue.py:412-491, async :941-1075).

The JS client logs a failed batch call and reports the requests it did not add in unprocessedRequests, so the result accounts for every request. It still rethrows an abort and a response that fails schema validation.

Expected behavior

A failed batch call ends up in unprocessed_requests and the method returns normally. Callers that catch the exception today would stop seeing it, so this is breaking.

✍️ Drafted by Claude Code

Activity

  1. added this to the 3.0 milestone on Oct 7, 2026
  2. added
    t-toolingIssues with this label are in the ownership of the tooling team.
    on Oct 7, 2026
  3. modified the milestones: 3.0, 4.0 on Oct 7, 2026
  4. added theissue type on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    t-toolingIssues with this label are in the ownership of the tooling team.

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions